From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CE41375AC1; Sat, 28 Feb 2026 18:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772301630; cv=none; b=rFTlUPOFZTmzY/wAFlCykNOe8FDBZBPC6rFo0BidI5M0Gba6gmvINod3X3BjEAm2I+OtBIe3o6lKES9IXetb2/KFQHz/J/98MAtHRbuMHaVXZN3hqtIV28zfxrU4pCWgQIgTB3MXh1R/Vo9j/dpFZkrmRRA4fk7LHvIVCSbCX5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772301630; c=relaxed/simple; bh=kHCRe4FxCpKOmGTFDbEGFmwKc5c1cbzYW9mRrhA/2zM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rEYsZCofNJjF/T3285U3LlOis4c1wDyVX/PkfMVlaCbthc76U3iB3CXMhDGqCj3Xe9+EZ4q61wPbsUYsU17H9RzmC5UkfL5Ve4gdw94DrnOx+jVH0mEq316O1qD7A9UDeDJf4YuDMBqRARkApBnVGfbean2Pu+i3fFir8NizyAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y5Ww6oOt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y5Ww6oOt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED299C19423; Sat, 28 Feb 2026 17:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772301629; bh=kHCRe4FxCpKOmGTFDbEGFmwKc5c1cbzYW9mRrhA/2zM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y5Ww6oOt+Lwkhhw6KzkZzqCLx2GB5Y6V/naeD+g/YVnGDnFJykP4eczgV77pSo6aG MwceHNzWz3tTt2nQUPDrqo4OH/XpY1QPEj4j2coQSntozKAfKLK4GkW1a2dH8TyfFX 5fZRLH0VdmJrHIj0bW/2HmeVqQPjJBYdjnqVErnT7/OV5v8nL9A1bM8hWX1+RqOS8L j+1xUXhbGCwz3WIiQx9BfetTOcQFR4X46hu07hQziT4+MpACIMVHSm6kKP/vnmJT2+ XJSlGPNpWjGSFDy3clti8s912U34ZnWDCJSJbRQ//cNsZce6q9IlsPUYRVrZhQYnRM 3szaWx8Sycbcw== Date: Sat, 28 Feb 2026 17:59:54 +0000 From: Jonathan Cameron To: David Lechner Cc: Francesco Lavra , Jonathan Corbet , Shuah Khan , Lars-Peter Clausen , Michael Hennerich , Lucas Stankus , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Puranjay Mohan , Cosmin Tanislav , Ramona Gradinariu , Antoniu Miclaus , Petre Rodan , Dan Robertson , Benson Leung , Guenter Roeck , Jiri Kosina , Srinivas Pandruvada , Matti Vaittinen , Marcelo Schmitt , Esteban Blanc , Jorge Marques , Sergiu Cuciurean , Dragos Bogdan , Alisa-Dariana Roman , Trevor Gamblin , Renato Lui Geh , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andreas Klinger , Paul Cercueil , Ramona Bolboaca , Marcus Folkesson , Kent Gustavsson , Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matteo Martelli , Marius Cristea , Heiko Stuebner , Maxime Coquelin , Alexandre Torgue , Kurt Borja , Francesco Dolcini , =?UTF-8?B?Sm/Do28=?= Paulo =?UTF-8?B?R29u?= =?UTF-8?B?w6dhbHZlcw==?= , Leonard =?UTF-8?B?R8O2aHJz?= , Oleksij Rempel , Haibo Chen , Salih Erim , Conall O'Griofa , Michal Simek , Gustavo Silva , Tomasz Duszynski , Roan van Dijk , Jyoti Bhayana , Mariel Tinaco , Nishant Malpani , Rui Miguel Silva , Linus Walleij , Lorenzo Bianconi , Alex Lanzano , Jagath Jog J , Jean-Baptiste Maneyrol , Remi Buisson , Christian Eggers , Mudit Sharma , Javier Carrasco , =?UTF-8?B?T25kxZllag==?= Jirman , Song Qiang , Dixit Parmar , Gerald Loacker , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v6 4/7] iio: Rename 'sign' field to `format` in struct iio_scan_type Message-ID: <20260228175954.1f0950a1@jic23-huawei> In-Reply-To: <120c7f33-4ca1-4d35-ac1b-b65362f1adfc@baylibre.com> References: <20260225100421.2366864-1-flavra@baylibre.com> <20260225101735.2368252-1-flavra@baylibre.com> <120c7f33-4ca1-4d35-ac1b-b65362f1adfc@baylibre.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Feb 2026 15:27:01 -0600 David Lechner wrote: > On 2/25/26 4:17 AM, Francesco Lavra wrote: > > This field is used to differentiate between signed and unsigned integers. > > A following commit will extend its use to in order to add support for non- > > integer scan elements; therefore, change its name from 'sign' to a more > > generic 'format'. > > > > Maybe Jonathan is OK with doing this all at once, but another alternative > could be to introduce a union to allow both names at the same time, then > we could make the change more gradually. Please do the union for v7. Not so much because I mind a global change, but more because the chances of merge conflicts are too high. Perhaps for this series just introduce the union and use it in the driver here. We can then chase it through the rest of the tree as a separate step. Alternatively leave it with a misleading name for now (so allow 'f' to be a magic sign value) and we can do the rename as a follow up. Jonathan