From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FAEC3ED5C8; Wed, 6 May 2026 18:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091178; cv=none; b=lwXWrf4KlRgzz4e00AeFcz2q4gjs0yZx6kK/+VvuEl1FPMY15iysQM0zQVgPm3n1Xkq/KF2V18d+lH/7MRBp2w1Ot6bazZOgxUooPsDC6tIQ5QcSRLKtMkwKTxCemvmReBuNp1PfzmZ0X16008l93ZxSK7bonhfYKbQ5FEPArBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091178; c=relaxed/simple; bh=FhJgyONvvTi9EeHcdBQw/ziyoLtmCuVthg18mTynIMs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vC5t7J9JUfFNkFJbuMy5grjSpamKZw1rroam0rMBdH8LCQrRidgNfongeX+0D7U4BRI1EneRDITF7yaSTZvWN68P1V6zUIeosoDa57kk9F/5GtIjoh86QPp6rQwhaB5fuyGR3+9Jd0A3IWNKn8Fzv+Usn5jb1uR9eUbq00ztog8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YxeynPjR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YxeynPjR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9972C2BCB0; Wed, 6 May 2026 18:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778091177; bh=FhJgyONvvTi9EeHcdBQw/ziyoLtmCuVthg18mTynIMs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YxeynPjRA+kv0+SSEOVRGm3jEfNkjp/00TZ1BzhgPJxHj8KhV4OywWmLX57IMB0xN bFXzsqarTEugeZAbai998m8KTEkNOgODXa+BlMZ+JRdiCL9JFLjTZqTtj8pQUOPzEm qDY1PL206tILmMzoqGpckfIys6rUAue8A/Xeer+YSDj+XBeshRQ0RE86S4sWPrNmpS ijfgxhJbx3IbSc/ajFNAjXgjjymed6l1VZq4cMKofXIjZq8evrwzCEzbVs7SQj4ssZ fsxzf5A7Kp5sHRD58SNFj3NI3uO30naZTGfaNI79MkgeYrp5OP7U4njepjQvPO1IHf yWOa0zcUsVMLA== Date: Wed, 6 May 2026 19:12:49 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Felipe Ribeiro de Souza , andy@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, paul@crapouillou.net, linux-iio@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v5 0/3] iio: adc: ingenic-adc: use guard()() to handle synchronisation and refactor lock-held helpers Message-ID: <20260506191249.18d5dd1f@jic23-huawei> In-Reply-To: References: <20260506022454.128169-1-felipers@ime.usp.br> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 May 2026 12:20:27 +0300 Andy Shevchenko wrote: > On Tue, May 05, 2026 at 11:24:27PM -0300, Felipe Ribeiro de Souza wrote: > > In drivers/iio/adc/ingenic-adc.c: > > - Refactor ingenic_adc_read_chan_info_raw() and ingenic_adc_enable_unlocked() > > - Replace mutex_lock() and mutex_unlock() calls with guard()() > > This version LGTM, > Reviewed-by: Andy Shevchenko > > In case you want to cook more cleanups, I provided a couple of side notes. > Applied to the testing branch of iio.git thanks Jonathan