From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F2B3AB47E for ; Thu, 21 May 2026 08:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352646; cv=none; b=Z+bR0ym21xxrZTXMZ3U6PCaVBUB8HYwLCKEbU1CmPL2jPOlWIXNjtwo7fyx+awOTxBJ0qkOYtTd0mGBzVBkYIjblJrjqTKCk83xAQ9kediUlzipO0dC7AAoGtJBp0234F7w3khV6kl4VVdIjw1GCOk//iJ+YG9RrZNorUBHV67s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352646; c=relaxed/simple; bh=d5jcui5x9J+nHSVyJps5DuSu5oenM0O/Al9uUGEdnso=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qM5OYujH8gmLsYz5qrIw8jVASgdhSTXeMZILAMDINhdqbXvKWNFl+q9qvyzPe0Ry9995fdodIU4NfQyfviqFIDH99mKjRsLeOapSUwXYZ+3MMC+RKbUvMCBur7H+wm0utmRNyu11aylKf1N5ulG0Cg2NGcXYs78LDPT9j2/gagQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SdjF4a++; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P2SyLYAz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SdjF4a++"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P2SyLYAz" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L7AR0q119201 for ; Thu, 21 May 2026 08:37:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4jemJMg1mPxTimQgHduXv2Tk1YXpvQTVBHPayB9K7NY=; b=SdjF4a++R9b8Imh4 M50gCFCW0es8kE+PRhzsu2IUk1csQfkF4V/6z7xG3YVTpjNfX/FdQgJw91FtGDmp k9o+F9H/tC9kwoUMlnjCMAzagYOfOb9z4PpX90oOtPpjcMhtCJ9oN4Zi67xTunYr RiCN3SuaU53vG7krEpjKUJicnQdvkOsKxwNxHDbUGDL3G5h0Tu5B+4wjQwKDL+gO Kg3xPNU14w4iBOj8Va9vS1r1drJyibztFx7S8CVulTr9f+zLqNV6/DB/o/UCj6IG dWnVFr2hOHZp3MU38CH3ubZG3lkrooNxrIQn3SErxclSxBUFc3foFsk/iuC9/aeO 3iX1kA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ee8c18f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 08:37:23 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d6bf346adso130047361cf.1 for ; Thu, 21 May 2026 01:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779352642; x=1779957442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4jemJMg1mPxTimQgHduXv2Tk1YXpvQTVBHPayB9K7NY=; b=P2SyLYAzVU852/o9UF09NQ5SCvJs3Mn8gcxOFpP+KDWc60SSa1mj/fpG7Pk5F5p4pf IU5RwPSjdWTVRH9mfSPO+P0LCYtjzrE5Ve8aiVP0lwSNoHEQiavIF0vAcBdf9MGr7zRv w6uQfY/l27lS6NVccIOYFnqNq8sSqpYpaTFrWQ7/Us5JruYYgDF1NToKWZZcoofscFFC bD3ZSKXVPpDgiobkPZuUk+SVBIRW7YMoaHAD8zl/5Yx5iS1yv0chYpqCr6HbwsUr70Jc cQWQad4Zb/PBsqMyzArh00v/oapQldJLObsbM4Ka4RYl9yL21e8uMLDWQqHXBTTuARc5 Ardw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779352642; x=1779957442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4jemJMg1mPxTimQgHduXv2Tk1YXpvQTVBHPayB9K7NY=; b=B/Z5+ztsteTN2/zSJGjdkpdktYl1EaJkg/n3+T5P7ZlETwshWWRwES2Y90G8dExXXD euucc6YV25o/eQrGl/K58os5deCVVJTjzMC5nM6J4mLLlV3QBDiR/njXNcXSJ6EtCuWu V7oKeTW9RDZoqAjZCxgIGh0nElZ7salObeGWtaCogaQtD/+U4ZKgew0n3qgMLuDpHKQR 552jPX9sTK5JsVePdaEb3FL2QZLBt0mx6J5oIGKHSMRUdlhvxqPhWZciWpvn+t8eHCxP Ci/PZ3R+hwjl5OC1qD9x9dH2grNKA7ElQQVBGiTMy6HLXJduLGRZzDgeyCV3Ogs+cdDn qPuQ== X-Forwarded-Encrypted: i=1; AFNElJ8T367NHmSVcVU2QmLLrROSV2aLEiDDur2nbG51bS5ZDbbTAlpbc1uBSLxv3Sy5c8tCXDvJk510w6Aj@vger.kernel.org X-Gm-Message-State: AOJu0Yy99W3bPiHY3OiBe/0V+jfcnpHjyXZHgQz/YrrbCXdsyeeuvILZ Zr+xNgD2JYZoliv/FZztShh26lAXFuwUThjbnAKlFQZ0nj86T5/4I7D5hw7ZZeXY4rRoD20jn4k zpJ1iVoBG6NNu9V4eMYw93Olzq4H+HyfnQ/YfNfb0ftMSmhF/XsQdSkvg9xxUObfd X-Gm-Gg: Acq92OGANiUuTAY09nA8p4+9U50rE7tXJjfvZ8TlHBXqVH+RVDkao10rgvBKU8A5rmd QDEgFa7BPbTO4Ru5aeJ3v3ecfx9DIx/JFPDxJ9tp4IvFuJtGqYTfyXSAmJ8AYoRfl/mlWZy9fsP 0Xoxs9KiGlGtJYuDCG8lVyFM+nvsVQI46m40BEiRIm9BaizjUMXaDnuLTSqeQ5xpSiAqkfCCqbI FqQSWv8j//1XkWT0rcDC2ShseRzmKn7XdaLvw/i9qdNLqPHai0M9Os6cM79fY/ShoZHcMTd7GAN r2ZzShUMeqUMERbTX/RiY4/DSF5rX+Lga/np7yMVwfpYetOTiYJHY3d0vOwha+KWzVywUTJrRdc RySTLeoWVxGgSwczAmpmOM4YXYGgLlIEH8OKccqiyfnR6POYBnpU= X-Received: by 2002:a05:622a:2590:b0:516:51da:ae52 with SMTP id d75a77b69052e-516c555a195mr23279761cf.33.1779352642359; Thu, 21 May 2026 01:37:22 -0700 (PDT) X-Received: by 2002:a05:622a:2590:b0:516:51da:ae52 with SMTP id d75a77b69052e-516c555a195mr23279411cf.33.1779352641766; Thu, 21 May 2026 01:37:21 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903caede9fsm10502405e9.14.2026.05.21.01.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 01:37:21 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 10:36:28 +0200 Subject: [PATCH 05/23] powerpc/powermac: fix OF node refcount Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260521-pdev-fwnode-ref-v1-5-88c324a1b8d2@oss.qualcomm.com> References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> In-Reply-To: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> To: Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Andy Shevchenko , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt Cc: brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1407; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=d5jcui5x9J+nHSVyJps5DuSu5oenM0O/Al9uUGEdnso=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDsQiYCDxIrOzFNRB+zSgbriyAtuSvWozaQ6JP bdrg27xjuCJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag7EIgAKCRAFnS7L/zaE w7SsD/9c6wDjuVBS5Sm/VFhqZkK+tS0GvHXg+zY0D2yyFaXX4voIhl4oa6+psFsIHJX3kjbj8gk 2NaBcZj5v5qpmW4jExZj22fpTdHOKFtVnDCK+8UF2T7u2gqPrZwH7Y8YQBBFHmQGJLOoPuLHZSJ Ic6H+lisu1XnF+Db/iCRftzqK+Yj256ww6xHyvHM0eYPDKNcHh5k24Vw+F5NmEuz8DDwWPy314p sKpJutaZQ4VvhNThPdbll7B5GU2V9eLiV6uG3hDBVj0rKkZETI0tpdV1i2MNBoLEEmjm9lLgtxS H/iU9SJJDHlslkgKRK4iIa6Givk4naromKliy+6A89h5XzhSVPELLtqZVPirswCcj38GXkDDNhx XdQFVaJ/Sz0+LeyiysiFYFgpV0q2SxNzEgM9dj/cin64KeXZn6O/32f8gdOxs4tbIcgBGZtHonO wlf4CnKF8bhdmRMTSssJYsH2zxYaYoK13u9LnsjPAmWUH6rRYorVVYEj5qcJh4TgHv2isVLkrU0 DrfnkK2UlqMZmTEfCWPTz4USoMsl8R3ve3p5uaTZjKaxhuvE8U0Ok+U7ZGIMSMm1Y20I+yP+qFo WCb4cP/9+Eh3SybOcfnPyGnHxIFTEkX+zZNkZvRTcLA1Ik/aJdRAh+FEsokxVsD6vhm8fvFsvIk p1kCeIIqXvMimtQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: 9SPR-oGRWEEnTUgeOVHkF6aae5Gt2dvr X-Authority-Analysis: v=2.4 cv=e5k2j6p/ c=1 sm=1 tr=0 ts=6a0ec443 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=lFaTzyIiLygvDfm8gxsA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA4MyBTYWx0ZWRfX+4UDISID/6Kf CH7qB+VcIvrCTIHzX2ikGsAl4gCj5TQ4RYpO55JMyVjQppAcyNowEEPb8f9lGpNpn6ponqPG3Yd KrlKmlLHLS1ttgewcu9Dzak5q1soR9MOthM6JNJ2YbwK+hHdgfWI31U4HxdE8mqT2PXTQcgwWJw h2y9EHZb4JpcNRPHLf6geSMphkbn6brArC/uopp62YmhJpHCwu2EuNSL2NZHaxM/dokyLnPXCFy UzL36vDZX5VKYn42y58GBq5PP1nAU5vi/MQmc/lTm270upq35lv55B/5bB/QUPWsxNdZbCnxIoZ aEIfRF6zRzXyo0s2jKACeNTnIydB59Ee33LYDNqovZSbePN+YM6YX/SbSV2BCYAqm86GlzmxGKB izHGpTwa1qBjTgUxsx7y3KW/2Mf7BgaVP5aXwXIIL9VMW9uMlD8c6cfarjjFz/xPw9oksdKDdcj d8h8hZhpPR+GSDtc5rQ== X-Proofpoint-GUID: 9SPR-oGRWEEnTUgeOVHkF6aae5Gt2dvr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210083 Platform devices created with platform_device_alloc() call platform_device_release() when the last reference to the device's kobject is dropped. This function calls of_node_put() unconditionally. This works fine for devices created with platform_device_register_full() but users of the split approach (platform_device_alloc() + platform_device_add()) must bump the reference of the of_node they assign manually. Add the missing call to of_node_get(). Cc: stable@vger.kernel.org Fixes: 81e5d8646ff6 ("i2c/powermac: Register i2c devices from device-tree") Signed-off-by: Bartosz Golaszewski --- arch/powerpc/platforms/powermac/low_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c index da72a30ab8657e6dc7e6f3437af612155783d8f9..973f58771d9636605ed5d3e91b45008543b584d3 100644 --- a/arch/powerpc/platforms/powermac/low_i2c.c +++ b/arch/powerpc/platforms/powermac/low_i2c.c @@ -1471,7 +1471,7 @@ static int __init pmac_i2c_create_platform_devices(void) if (bus->platform_dev == NULL) return -ENOMEM; bus->platform_dev->dev.platform_data = bus; - bus->platform_dev->dev.of_node = bus->busnode; + bus->platform_dev->dev.of_node = of_node_get(bus->busnode); platform_device_add(bus->platform_dev); } -- 2.47.3