Re: [PATCH 1/3] of/fdt: fix misleading elfcorehdr reservation success message

[Rob Herring <robh@kernel.org>]

On Mon, Jun 15, 2026 at 01:15:01AM +0900, Sang-Heon Jeon wrote:
> fdt_reserve_elfcorehdr() does not check the return value of
> memblock_reserve(), so a success message is falsely printed when the
> reservation fails.
> 
> Check the return value and warn on failure instead.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
>  drivers/of/fdt.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 26f66046cc32..d985c07d7c5c 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -479,7 +479,10 @@ static void __init fdt_reserve_elfcorehdr(void)
>  		return;
>  	}
>  
> -	memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> +	if (memblock_reserve(elfcorehdr_addr, elfcorehdr_size)) {
> +		pr_warn("Failed to reserve memory for elfcorehdr\n");

I would think memblock_reserve() should always succeed and if not it 
should print a message rather than having every caller print a message.

Rob