From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C09651DF980 for ; Wed, 2 Sep 2026 20:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788380234; cv=none; b=RzqSd8jI6ic4IVoe7Jv/r22u56VXyArUrGaOsi2xAgyV70Lg2jTkx75pgadtb3l3x8qmeCf+86OVUh2wGNegfsMT5HtGnTU+k9yUsE1bQuOyuIQmaxu3ewT7o1JKszRXy3hunkSd7h25STAAE4qSDxJsCIwbn3HcAQ770wZY714= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788380234; c=relaxed/simple; bh=X2JKT1rUwXBxTwGr+cj85lMsd/xn6QXY90i0q/UqNeY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YZbBROlt3uDtw1TfAAGPp7Jr14Mcc4/JdYnwW5qCCV19IWinowkF0bz9Bz39UM9Rjq2rJqajMiShIKh3ChCtnX20ISU0hPCtca1QtmW1PhMQ1nC5qPXsSFBhz9D4NvbLrc1n3EpAY6aarCC2igtxQNE5r4vWLDIpoRtDq+Mr5qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YH71TVQX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NGhlfhhI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YH71TVQX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NGhlfhhI" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 682KH5g72581012 for ; Wed, 2 Sep 2026 20:17:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=5pBRbhbzo1P cOFREec6Gs1n8ea1WgM8d8Z6/KvlnlrA=; b=YH71TVQXwSMcn3Fu/Uff9SK4nzC 54IULE63yNKCuMTPEd49MGBUR9KKNNIN/QVTquPXtzIjMppcDurhMW02H3mw/HoK QpIWWpHShP1aC26/5Elx8gXqpOsaRWjvdKkLXCUSyLf1mZfjfZiZSS4H+mV1c8Id 88ruhQ6RqKJIryjdqDsY4tS8gLQX3HTIOvazfZQQPjxVQiBY+Ozb/umbSbvelZan fwT6i3hl7FkpHSIJoP7vd8T9SpNtUG5AcXWPwBduK7YLtF34TKGVzNjoOtZ3ZMdN eB2EhtinE7Jy1HoAhoeMJRx0yJorifYNZ8msk5ykeSvB8lt2qUSCYqN0DjA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gej2cagx2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 02 Sep 2026 20:17:11 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-398d7e0f3b4so2058520a91.3 for ; Wed, 02 Sep 2026 13:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788380231; x=1788985031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5pBRbhbzo1PcOFREec6Gs1n8ea1WgM8d8Z6/KvlnlrA=; b=NGhlfhhIkfxPytweIqetPW3pciB7bfm58LkAPcWep6KeldejDIrvCmHl+sUYNlyXkR qEnklvO6GF+VH8+su37CXGaWCgV6GSc3bVsJoHoLxlMCzyuFfomXL9DxKDwaZDiiCTWT S2AyvxI9nCIOlr1gWgVrSnGiuz1bmNknGa+exE0hbaLkN3f6O0yVK84w/HpA0ZIPUTqj pacZV+LOxRkK7y+lbd9COVjiwnrTI3Mit4iY6i1JU+RIW48m8wv5I2wCrO/x760SzeO5 UTg3DHfvBGHr8V7/nLHUDLIFKqR7WGnrXIv+a0BBt89D4yiP/A/eZOPJMYkks5sQ3Rgh 5OVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788380231; x=1788985031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5pBRbhbzo1PcOFREec6Gs1n8ea1WgM8d8Z6/KvlnlrA=; b=WK1NjkVSbbFJd7Q/lchmOobjsgxzDbs+YCCCXcCbnt8gpnpkKkC3VOTFCkkpmF0KyM Izg5mSSNFT56vGgalsP1FVDylhlkEZ9qaFA4FzfBYXNiAzy/cRXbQn6uI+ra8CBVK+XQ kwmXpeLbldLjGf9jNlBfLAIldshPuIlwCz5N8hMFFtZ8if0CllN+Ys2ZeFXPnCJ6/u8t H58xQ0XVjECx4UBZwQw1buBvBiutIUc7+MxMG9blZx+ZTLql5MV9Q3xZWuuBlAKOAnzH 3suywma4AAMldQwsCAalqdzTFYKkVugFZYN0An0ngoBwLlFEOuYUhwlTilG7Xs+CMG/U q+pQ== X-Forwarded-Encrypted: i=1; AKwUvBxr9WGBeHfnGzEum7dhasW3DTrQFYKr0wPsgdcCMmZhZJYCvYEKnicoKHIx7iqSsbAd5TMbRlLIIcXB@vger.kernel.org X-Gm-Message-State: AFuF++n+/X5r6oLr55fL/1y7guJCNU08wPrzK13qMEHhnzvrmKsBXfVx 9XlRREA/G/aJshHqsgXM2MWxc5a2ye++AwdBJdcBrCT2b3UzVh9f4ShuekQF0i8P5L/8cc9OAeR gcOF7Qd2VaJcNyjCLVvoryCiMF1iarDZmPuCGICmiZPdaNDwmP5qFhBOtlY0ElPU9 X-Gm-Gg: AYBFou3fTmS+dvEAgQDIYwYGTxw9V+P+JisFjhzhg13um3/D0FBNSuMtUqpKXHfs3Oh gsdPs0TCKJXkGdbIlxICVv8PvMLjdGain8bNXafXCPYG8R/zGMR7cluAtda+Cej/BNVV5SEl3zf sMSSF9oPccFAW6bGujdeUJDk9E9f6YucQn5uIWzAPLFB0WUDHN0rz3fd1SretM/VOJ8Zg92C2B5 vA2PVcBYqZJP+/tUGqx3tNyscJcns9FX30an2RVg5vtdsbNbms+gPaDVqG807bgrGcw/Ig30MNb 9/K+JAybTAusZ3WZTgN7rhSRSRhaovgN/CidFfKzjkEBRu5TDFX0yWjcEPyQnow4x63vdntJE/u rTMdZ0WrkWrcSsfjyK1TT86BOFOg= X-Received: by 2002:a17:90b:2785:b0:396:5cdc:4bea with SMTP id 98e67ed59e1d1-39aedeb83e0mr11608230a91.5.1788380230685; Wed, 02 Sep 2026 13:17:10 -0700 (PDT) X-Received: by 2002:a17:90b:2785:b0:396:5cdc:4bea with SMTP id 98e67ed59e1d1-39aedeb83e0mr11607901a91.5.1788380228811; Wed, 02 Sep 2026 13:17:08 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33256414c60sm497205eec.24.2026.09.02.13.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 13:17:08 -0700 (PDT) From: Mukesh Ojha To: Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Paul Cercueil , Anitha Chrisanthus , Paul Kocialkowski , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexey Brodkin , Laurent Pinchart , Tomi Valkeinen , Michal Simek Cc: Ryan Chen , Billy Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, Mukesh Ojha Subject: [PATCH v2 2/11] drm: hdlcd: Use devm_of_reserved_mem_device_init() Date: Thu, 3 Sep 2026 01:46:31 +0530 Message-ID: <20260902201640.2024648-3-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902201640.2024648-1-mukesh.ojha@oss.qualcomm.com> References: <20260902201640.2024648-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAyMDE3OSBTYWx0ZWRfX4algGSfrUwv/ kfmNMlwzKxyxV4TLhjLYRWRoN2fVoSgVVfp8z+4Nc1Kf+CGSbeqSJxFFBL1znWju/jnmvw5J7Jr +UeyI87GX+YHbAKTvXsH0VJC89VMT5E= X-Authority-Analysis: v=2.4 cv=G+ss1dk5 c=1 sm=1 tr=0 ts=6a988447 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=zu8Q1U5i7KxegdXecekA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: bGnNnkP4kuhVNzEbIB54_tNSPRBafJq- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAyMDE3OSBTYWx0ZWRfX+HMfvpIdcjKE j5L8uUTX4ZMDwPCDCWObTg4Ep8XlQoFhuR06OFcqKs926eHJHr5EYAy+kEij0hn27P7YB53jvdw S45An/n/F23DwlYyqrOQFOTy5fUDCkGJUOs2l/HfBDUqR0I2GwWjWH0Rx5ITT3nSTVU/mVFfC7w 7wBEw2U38oZ3D6oMSXBtv7KDbw1LQE1kP30ROhSFgrKJo6zocUyBnbS3lhSgt+oOrdZ6bfVXkUd FTVQDD+uMSEblf/pIwJOUfyAEC/rre844J3WtlBhMFwEpyzyPWUvBPjYMZ8hrBQjWG8rCAFn4yq xggPRLkcYjYajksVLzh90VUBrSIF4492h3j1GlkH1we8RpkKEu88L0UdYXSfrcYEce5/lK2wU3u MHYYsH5mDW75vVCsIE11oCV97Ae/IZ0i6P1TsAsSBwuIBf64emazE25MOT3Vwyt4cbmzIB3F8jW wyObiLJEWImQ3bpAZbw== X-Proofpoint-ORIG-GUID: bGnNnkP4kuhVNzEbIB54_tNSPRBafJq- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-02_05,2026-09-02_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609020179 Switch to devm_of_reserved_mem_device_init() so the reserved memory region is released automatically on probe failure or device unbind. Remove the three explicit of_reserved_mem_device_release() calls in the setup_fail error path, the bind error path, and hdlcd_drm_unbind(). Reviewed-by: Liviu Dudau Signed-off-by: Mukesh Ojha --- drivers/gpu/drm/arm/hdlcd_drv.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 81d45f2dd6a7..67466fd441d5 100644 --- a/drivers/gpu/drm/arm/hdlcd_drv.c +++ b/drivers/gpu/drm/arm/hdlcd_drv.c @@ -134,7 +134,7 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) version & HDLCD_VERSION_MINOR_MASK); /* Get the optional framebuffer memory resource */ - ret = of_reserved_mem_device_init(drm->dev); + ret = devm_of_reserved_mem_device_init(drm->dev); if (ret && ret != -ENODEV) return ret; @@ -164,8 +164,6 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) irq_fail: drm_crtc_cleanup(&hdlcd->crtc); setup_fail: - of_reserved_mem_device_release(drm->dev); - return ret; } @@ -316,7 +314,6 @@ static int hdlcd_drm_bind(struct device *dev) of_node_put(hdlcd->crtc.port); hdlcd->crtc.port = NULL; hdlcd_irq_uninstall(hdlcd); - of_reserved_mem_device_release(drm->dev); err_free: dev_set_drvdata(dev, NULL); return ret; @@ -338,7 +335,6 @@ static void hdlcd_drm_unbind(struct device *dev) pm_runtime_put(dev); if (pm_runtime_enabled(dev)) pm_runtime_disable(dev); - of_reserved_mem_device_release(dev); dev_set_drvdata(dev, NULL); } -- 2.55.0