From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.69 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793214190; b=ti5KnhLGZon556gqvScLHx1VQboJI+z0Xoofe9/Vc/5MPdMmz12P4EO5JTkvMPUwTsaV oE0JhPnkwhBKjB3eLAhMKI3efHiHwHhwUU2LqN9FT9T9Me4eO900PYvyWSmNJpwXftalT VM/ZuVMpCzQjXfxfYvPa1AVYFtV5HJriUAZfqFeBzGvcfvaQsw+oCVpN+H3dQ/zKIvqFu DoA6VXIPvQ8C5E0LBx41hkBaenrAs+HDxQK2m9NFVCZW2xvJg4vn3Tiv55+PM+2HAZ4uK ftfYX1bHCOUGt7gyZqgPoaT3o3/ztjYWB3EqnOAh+qnBP68zd+ICmnn41d/Xcn1ABkw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793214190; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Reply-To:Date: In-Reply-To:Mime-Version:References:X-Mailer:Message-ID:Subject:From: To:Cc:Content-Type; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=Sgb2dNewl2FLZhrBWebIhtzHJexLEraZvFtvhO56BmIv+Ze4iclq5HEPgYQBpntOdvZM cFyMxcCE7mnv11BDj2F1V80kwdFwVEoewIOTqqFphHjtaxnz7b5jzcuiYlYDtZ7yTT8aB cjNGSyDvxdFrV5GUNjlOthlKmORgSP6oKG+iP6HmWVEbVFYsDi5IR0gxl0PGCeqydqg2H nZuE/RT8p5ZX3TyqERU0Wpzj3UtZuGTI299AaVHKLNhsLO95pIUqXKW6kI9qR3AD0d8MM 3dgOgRkJiiuFhW0tRrbIsIsvUn7qkMxW8hMZHPy1AHZ6S2g+mSgsS1G0/HtDRtjHjPQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=pGFlp0EN; arc=none smtp.remote-ip=209.85.216.69 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DF8A60A5BCA for ; Wed, 28 Oct 2026 19:03:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2DF8A60A5BCA Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=pGFlp0EN Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3adeba76cadso929665a91.1 for ; Wed, 28 Oct 2026 12:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793214189; x=1793818989; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=pGFlp0ENKqWM3zxMe4l0HO32iIDM9FQtMJdGG2kuCIimYi/ALlynhAd+s/4RFHCyHP QWVo5FfdN7XfHpv6JCiYLeUQxNzWAPnLkzbeaBWX1HPjOYkK1GwSscaWUlC64P68wjOO H3o7khGN3TrIlClbtiKyWZpUspnBmfo93DPzjZsqVtDpGs9Ey9Zw1EaTWH+AxbdxLFIW cOZSqdrQg/XPvb5EZKmroN8Ni0EFl7myAWTx6gsOyByi529y3aT+akl8rlmJjrCr5Ue7 oYDohpLF7bkKWQPGrgi8YGoW47Ac7/CEq3JkJRgnPTYxZnDlg4OR2/EywXGuakFg4eQA Fxvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793214189; x=1793818989; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KIzhXXz4HgfGAdkUpoWB/z0OMxuU8qDaDSAd1VOEpew=; b=DIrhy1FZq2ufkPiwX4spox0DqqmUoA3jkaJZry/UpTPTxwT3LnJnNY6VyJc75xopXR USbtBuulsjBZDk9gfKM1q7P1bIsHvOo4HmDxMw7dWWoa2BnLepARHyrFH15q03vxVXjq XSQZAP6a4A46A+OmcstPBooFfq3RAyymdXiOCAzZzdsaU1YlzExQSN2uEc+6pEFQdVB3 a5Tca2g/TPnqiBAktXA5P1uopXNGXeHCvB3+jT9C6mL88oONrJlpeNVxryBhxFfE4k7Z Uoe3VOuZFtBCWAs56iRyq1gvf+3Q7yWrZMRY1ZwAhTv3P17N0tBpuipU5YvfUMR7pvug +Uog== X-Forwarded-Encrypted: i=1; AKwUvBwEl3Msk2vEb61dv38BtXUXG3Bfeub0FaWRCtqlk3nz4nhd4S4EBweq5ufZ72sJYnM9hWZ0uMOp/PJk@vger.kernel.org X-Gm-Message-State: AFq9FYI49tZxgjY4M7ta/Fj/C1WIKzEsoGUzBQLPdwEf0cD50yXzM6Pw eEWssCEL38nhLWkg2AJCGoX4eu9xLtAvMI1E3QSFqRjAJyJmBDaY8GYgPuGjRdEDUJWF2PvDSYz tcXfaiw== X-Received: from pghw14.prod.google.com ([2002:a63:f50e:0:b0:cda:c74c:ca8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4b86:b0:3ac:a11a:7c84 with SMTP id 98e67ed59e1d1-3ae58195de0mr2519930a91.65.1793214189231; Wed, 28 Oct 2026 12:03:09 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 28 Oct 2026 12:02:58 -0700 In-Reply-To: <20261028190259.1819571-1-seanjc@google.com> X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261028190259.1819571-1-seanjc@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261028190259.1819571-7-seanjc@google.com> Subject: [PATCH 6/7] KVM: Plumb the full request into __kvm_vcpu_kick() From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Nicholas Piggin , Atish Patra , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Teodorescu Content-Type: text/plain; charset="UTF-8" Plumb the full request instead of just a "wait" boolean into __kvm_vcpu_kick() so that it can use kvm_request_needs_ipi() instead of the flawed kvm_vcpu_should_kick(). No functional change intended. Signed-off-by: Sean Christopherson --- arch/powerpc/include/asm/kvm_ppc.h | 2 +- include/linux/kvm_host.h | 6 +++--- virt/kvm/kvm_main.c | 17 +++++++++-------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index bbe7378ad0ef..011dc422af78 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h @@ -38,7 +38,7 @@ */ static inline void kvmppc_vcpu_kick(struct kvm_vcpu *vcpu) { - __kvm_vcpu_kick(vcpu, false, true); + __kvm_vcpu_kick(vcpu, 0, true); } /* diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 9db42f58c561..035b1bdd8c09 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -1570,11 +1570,11 @@ void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu); bool kvm_vcpu_wake_up(struct kvm_vcpu *vcpu); #ifndef CONFIG_S390 -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force); +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, int request, bool force); static inline void kvm_vcpu_kick(struct kvm_vcpu *vcpu) { - __kvm_vcpu_kick(vcpu, false, false); + __kvm_vcpu_kick(vcpu, 0, false); } #endif @@ -2314,7 +2314,7 @@ static __always_inline void kvm_make_request(int req, struct kvm_vcpu *vcpu) static inline void kvm_make_request_and_kick(int req, struct kvm_vcpu *vcpu) { kvm_make_request(req, vcpu); - __kvm_vcpu_kick(vcpu, req & KVM_REQUEST_WAIT, false); + __kvm_vcpu_kick(vcpu, req, false); } #endif diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index e1a9da8b43d7..f1792256576b 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3913,7 +3913,7 @@ EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_vcpu_wake_up); /* * Kick a sleeping VCPU, or a guest VCPU in guest mode, into host kernel mode. */ -void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force) +void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, int req, bool force) { int me, cpu; @@ -3948,14 +3948,15 @@ void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait, bool force) cpu = READ_ONCE(vcpu->cpu); if (cpu != me && (unsigned int)cpu < nr_cpu_ids && cpu_online(cpu)) { /* - * Use a reschedule IPI to kick the vCPU if the caller - * doesn't need to wait for a response, as KVM allows - * kicking vCPUs while IRQs are disabled, but using the - * SMP function call framework with IRQs disabled can - * deadlock due to taking cross-CPU locks. + * Use a reschedule IPI to kick the vCPU if the request + * doesn't need to wait for a response (or there is no + * request), as KVM allows kicking vCPUs while IRQs are + * disabled, but using the SMP function call framework + * with IRQs disabled can deadlock due to taking cross- + * CPU locks. */ - if (wait) - smp_call_function_single(cpu, ack_kick, NULL, wait); + if (req & KVM_REQUEST_WAIT) + smp_call_function_single(cpu, ack_kick, NULL, true); else smp_send_reschedule(cpu); } -- 2.56.0.313.g2479322e68-goog