From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8408C282CE for ; Tue, 4 Jun 2019 12:10:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABC3524A3C for ; Tue, 4 Jun 2019 12:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727580AbfFDMKg (ORCPT ); Tue, 4 Jun 2019 08:10:36 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:41634 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbfFDMKg (ORCPT ); Tue, 4 Jun 2019 08:10:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D48EF80D; Tue, 4 Jun 2019 05:10:35 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB3B43F690; Tue, 4 Jun 2019 05:10:32 -0700 (PDT) Subject: Re: [PATCH v6 15/19] arm64: Add vDSO compat support To: Catalin Marinas Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Will Deacon , Arnd Bergmann , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-16-vincenzo.frascino@arm.com> <20190601093830.GA13589@arrakis.emea.arm.com> From: Vincenzo Frascino Message-ID: <2027e092-2d76-9350-6c5b-7d3debc6a93f@arm.com> Date: Tue, 4 Jun 2019 13:10:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190601093830.GA13589@arrakis.emea.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Catalin, thank you for testing my patches and providing the scripts you used to reproduce the issue. On 01/06/2019 10:38, Catalin Marinas wrote: > On Thu, May 30, 2019 at 03:15:27PM +0100, Vincenzo Frascino wrote: >> Add vDSO compat support to the arm64 building system. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Signed-off-by: Vincenzo Frascino >> --- >> arch/arm64/Kconfig | 1 + >> arch/arm64/Makefile | 23 +++++++++++++++++++++-- >> arch/arm64/kernel/Makefile | 6 +++++- >> 3 files changed, 27 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 952c9f8cf3b8..3e1d4f8347f4 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -108,6 +108,7 @@ config ARM64 >> select GENERIC_STRNLEN_USER >> select GENERIC_TIME_VSYSCALL >> select GENERIC_GETTIMEOFDAY >> + select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN > > This select needs to also depend on COMPAT (or rather be selected from > the COMPAT menuconfig), otherwise, trying to build this series with 64K > pages where COMPAT is disabled, I get: > This is a very good catch, my bad, will definitely fix in v7. ... -- Regards, Vincenzo