From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36E9F31AF2D; Wed, 4 Mar 2026 08:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772611841; cv=none; b=lZZ3WDGSUEONNdqOGKik4Epk1ftDy18NL2GrYAu/c+9QzT4otbvBnD60JFbVKMkcJ6rM6fdgGPX9TUjiSnv3/8MPsTCGIZV30026mHiIhJMTqjnrd/Kr5u7zfUbxjpdIjzrcxXnR2GJwoNx+A6YjvV1htRsgmupTrBfQ8MzyMGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772611841; c=relaxed/simple; bh=x/cjkUsrdE57qY9IYoGwEYkkvopBW35thxqhqdiJIAY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qWuhvGSvgt+RqdEXOutsXBPR4IGmtHyDVpLq8+D8Hgtin98j0UK18FBjzNEVfI9ReVC+I3Iu0jQJfERJD6o+WtCYCqi1pAmOfAsSk7Z82oDKQU+9vWLAivLB4uDVfKcPfNbvTZZ0fr0PkBY6OtaUyFdN9OL8aS0Inzkx7RMEMbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZvsY4JxF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZvsY4JxF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B53E8C19423; Wed, 4 Mar 2026 08:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772611840; bh=x/cjkUsrdE57qY9IYoGwEYkkvopBW35thxqhqdiJIAY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZvsY4JxFcYf52LCAM8zNIoCTUr/ugS8UrXI8DpnABve0PkoahFeUDVQyAZ2T7w5tc qvDxXw377nK660zLOZq0b1o4TMaqwXcThhKOlEpjZFL0bkvwxztXrr9ZfUwyJTBKr8 cQxEFx0psqwMRwqmtOZEExTbQ7fXQvjYQp1XY9q5+MJUrg2BO+qa42sUoMUFw/UKDM FTPPks6SNAe+9AFIQxr/FV9a/NoFSZsQPHrTqKnPcpAk+LPhi9vX+9vtaSsBZMqckd jCBvfJZ1aYZ2JCuOJ5wjnShT63I1i+NIZT0LHit09LZaUnxSAYz27d1DHaKybPv+SF oKjTezLFpLZ+A== Message-ID: <21ee2f0b-ae8e-40b6-ab13-e46f55c34254@kernel.org> Date: Wed, 4 Mar 2026 09:10:31 +0100 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 01/14] vdso/datastore: Reduce scope of some variables in vvar_fault() To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Andy Lutomirski , Vincenzo Frascino , Arnd Bergmann , "David S. Miller" , Andreas Larsson , Nick Alcock , John Stultz , Stephen Boyd , John Paul Adrian Glaubitz , Shuah Khan , Catalin Marinas , Will Deacon , Theodore Ts'o , "Jason A. Donenfeld" , Russell King , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Shannon Nelson , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org References: <20260304-vdso-sparc64-generic-2-v6-0-d8eb3b0e1410@linutronix.de> <20260304-vdso-sparc64-generic-2-v6-1-d8eb3b0e1410@linutronix.de> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260304-vdso-sparc64-generic-2-v6-1-d8eb3b0e1410@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 04/03/2026 à 08:48, Thomas Weißschuh a écrit : > These variables are only used inside a single branch. > > Move their declarations there. > > Signed-off-by: Thomas Weißschuh > Tested-by: Andreas Larsson > Reviewed-by: Andreas Larsson Reviewed-by: Christophe Leroy (CS GROUP) > --- > lib/vdso/datastore.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/vdso/datastore.c b/lib/vdso/datastore.c > index a565c30c71a0..2cca4e84e5b5 100644 > --- a/lib/vdso/datastore.c > +++ b/lib/vdso/datastore.c > @@ -41,8 +41,7 @@ static vm_fault_t vvar_fault(const struct vm_special_mapping *sm, > struct vm_area_struct *vma, struct vm_fault *vmf) > { > struct page *timens_page = find_timens_vvar_page(vma); > - unsigned long addr, pfn; > - vm_fault_t err; > + unsigned long pfn; > > switch (vmf->pgoff) { > case VDSO_TIME_PAGE_OFFSET: > @@ -54,6 +53,9 @@ static vm_fault_t vvar_fault(const struct vm_special_mapping *sm, > * Fault in VVAR page too, since it will be accessed > * to get clock data anyway. > */ > + unsigned long addr; > + vm_fault_t err; > + > addr = vmf->address + VDSO_TIMENS_PAGE_OFFSET * PAGE_SIZE; > err = vmf_insert_pfn(vma, addr, pfn); > if (unlikely(err & VM_FAULT_ERROR)) >