Re: insmod hates RELA?

[Keith Owens <kaos@melbourne.sgi.com>]

On Fri, 6 Oct 2000 12:26:28 +0200 (MET DST), 
"Maciej W. Rozycki" <macro@ds2.pg.gda.pl> wrote:
> The linker tends to create empty .rela sections even if there is no input
>for them.  This actually is a minor error and until (unless) we modify the
>linker just use the quick fix for modutils that is available from my FTP
>site (not that these modutils actually work ;-) ). 

Against modutils 2.3.17.  Does 2.3.17+this patch work on mips?

Index: 18.2/obj/obj_load.c
--- 18.2/obj/obj_load.c Fri, 08 Sep 2000 16:46:27 +1100 kaos (modutils-2.3/21_obj_load.c 1.7 644)
+++ 18.2(w)/obj/obj_load.c Fri, 06 Oct 2000 21:45:44 +1100 kaos (modutils-2.3/21_obj_load.c 1.7 644)
@@ -151,11 +151,13 @@ obj_load (int fp, Elf32_Half e_type, con
 
 #if SHT_RELM == SHT_REL
 	case SHT_RELA:
-	  error("RELA relocations not supported on this architecture");
+	  if (sec->header.sh_size)
+	    error("RELA relocations not supported on this architecture");
 	  return NULL;
 #else
 	case SHT_REL:
-	  error("REL relocations not supported on this architecture");
+	  if (sec->header.sh_size)
+	    error("REL relocations not supported on this architecture");
 	  return NULL;
 #endif