From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 14 Aug 2012 17:47:59 +0200 (CEST) Received: from mx1.redhat.com ([209.132.183.28]:16676 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903553Ab2HNPrv (ORCPT ); Tue, 14 Aug 2012 17:47:51 +0200 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7EFlmu1011707 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 Aug 2012 11:47:48 -0400 Received: from warthog.procyon.org.uk ([10.3.112.16]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7EFli6x019303; Tue, 14 Aug 2012 11:47:45 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20120814151345.GB30856@linux-mips.org> References: <20120814151345.GB30856@linux-mips.org> <87d32us55c.fsf@rustcorp.com.au> <1344332473-19842-1-git-send-email-jonas.gorski@gmail.com> <31154.1344872382@warthog.procyon.org.uk> <32504.1344953290@warthog.procyon.org.uk> To: Ralf Baechle Cc: dhowells@redhat.com, Rusty Russell , Jonas Gorski , Linus Torvalds , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH] MIPS: Fix module.c build for 32 bit Date: Tue, 14 Aug 2012 16:47:43 +0100 Message-ID: <22516.1344959263@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-archive-position: 34160 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: dhowells@redhat.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: Ralf Baechle wrote: > +extern int apply_r_mips_none(struct module *me, u32 *location, Elf_Addr v); This needs to be in a header file, not a .c file. David