From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0EF9C43217 for ; Thu, 28 Oct 2021 21:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A65660F70 for ; Thu, 28 Oct 2021 21:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231393AbhJ1WBF (ORCPT ); Thu, 28 Oct 2021 18:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231346AbhJ1WBE (ORCPT ); Thu, 28 Oct 2021 18:01:04 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5DF2C061745; Thu, 28 Oct 2021 14:58:36 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id h11so13215359ljk.1; Thu, 28 Oct 2021 14:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c23uil5g78FyKWMRLgZ6hSpJ/5dZjfgZdNOr6DwhpW8=; b=fN/sghTD1TZsVWGg7UdNVpmnpsJmxwTIReywOn3iS879FfwyrwTro/6JMf4MaGrEqh 0NHbUx8tMPVCykH7rLffN6x80gPATjYeRH0X7Rke1JX3QXf40ikAhOl25K5S1BWImyNK Ws74ZKNhvY45yMsuq3FCKQn2UeHbmrvMca8cD6CCJ0R2lYcZYJkrBjgifHSN/5oWm7n1 lFtQ6NQQUb7L/5VMhM9mJogVid13IyjOv29tIrHnCgMGRUpYmk/I5bl/5lJ21eD61OSt uVSSMkzEczkDy+3W/RlWkglTIAMMvdWcaEVw6izXBz+EOktxUqL8EL8FpyIQN0i0+0ax cKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c23uil5g78FyKWMRLgZ6hSpJ/5dZjfgZdNOr6DwhpW8=; b=1n52YYDkTaUwLAN4/m9qcwLr6k0p7iQesqOlEWUPLZVUC6Rzw5c6mU2SJF5RlodjJT 71tuVdSFpp1hhbhNLzYzRasYI2CMCvIZJu1HuwKLsRY4Z9Xp8vdONz21H8kqe+Ina36b J02ZPAPId6b/N8Tyr4dqkmG8QDcTdW8oxnZBs/h6sJN0dsrEDTFiIYzhf6a/z4804N8c O2j1dGjQyro2dTo622efJVoohVAR5nJmA9nLmk6cML7u40h386CSDy1giPWtwurVdGYF Q3hQKQjIc9p0OHSOWwr8+Y1MiRUHIgbya+hp+x8Q94VaVpTgIXKJUHpeUHyMlAHdrzcV iojg== X-Gm-Message-State: AOAM530wGIeiaZAaQM3Bc3kvBNVPgDG0Z7Bi55QTXfYldUiQL8RzQbU1 FhMI8uJJeXAkzCNyUw60aMj7NpJ9388= X-Google-Smtp-Source: ABdhPJwU+yd9K4RKqPYJGKdWrmOtthi6PCwOlEc1MXGCnrTPBunu0coGknm3bBb5A7s1sx8AG2GBkw== X-Received: by 2002:a2e:b88f:: with SMTP id r15mr7402126ljp.157.1635458314886; Thu, 28 Oct 2021 14:58:34 -0700 (PDT) Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru. [46.138.44.18]) by smtp.googlemail.com with ESMTPSA id t17sm248350ljc.136.2021.10.28.14.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 14:58:34 -0700 (PDT) Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler call chain API To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Lee Jones , Mark Brown , Andrew Morton , Guenter Roeck , Russell King , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Linus Walleij , Chen-Yu Tsai , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Tony Lindgren , Liam Girdwood , Philipp Zabel , Vladimir Zapolskiy , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Pavel Machek , Linux ARM , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux OMAP Mailing List , openbmc@lists.ozlabs.org, linux-tegra , Linux PM References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-9-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <28560da7-8ab6-3bd5-b4d6-e34b21a9bbb0@gmail.com> Date: Fri, 29 Oct 2021 00:58:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org 28.10.2021 12:59, Rafael J. Wysocki пишет: >> +#define RESTART_PRIO_RESERVED 0 >> +#define RESTART_PRIO_DEFAULT 128 >> +#define RESTART_PRIO_HIGH 192 >> >> enum reboot_mode { >> REBOOT_UNDEFINED = -1, >> @@ -49,6 +55,167 @@ int register_restart_handler(struct notifier_block *); >> int unregister_restart_handler(struct notifier_block *); >> void do_kernel_restart(char *cmd); >> >> +/* >> + * Unified poweroff + restart API. >> + */ >> + >> +#define POWEROFF_PRIO_RESERVED 0 >> +#define POWEROFF_PRIO_PLATFORM 1 >> +#define POWEROFF_PRIO_DEFAULT 128 >> +#define POWEROFF_PRIO_HIGH 192 >> +#define POWEROFF_PRIO_FIRMWARE 224 > Also I'm wondering why these particular numbers were chosen, here and above? These values are chosen based on priorities that drivers already use. I looked thorough them all and ended with this scheme that fulfills the needs of the current API users. I'll add these comments in v3: /* * Standard restart priority levels. Intended to be set in the * sys_off_handler.restart_priority field. * * Use `RESTART_PRIO_XXX +- prio` style for additional levels. * * RESTART_PRIO_RESERVED: Falls back to RESTART_PRIO_DEFAULT. * Drivers may leave priority initialized * to zero, to auto-set it to the default level. * * RESTART_PRIO_DEFAULT: Use this for generic handler. * * RESTART_PRIO_HIGH: Use this if you have multiple handlers and * this handler has higher priority than the * default handler. */ /* * Standard power-off priority levels. Intended to be set in the * sys_off_handler.power_off_priority field. * * Use `POWEROFF_PRIO_XXX +- prio` style for additional levels. * * POWEROFF_PRIO_RESERVED: Falls back to POWEROFF_PRIO_DEFAULT. * Drivers may leave priority initialized * to zero, to auto-set it to the default level. * * POWEROFF_PRIO_PLATFORM: Intended to be used by platform-level handler. * Has lowest priority since device drivers are * expected to take over platform handler which * doesn't allow further callback chaining. * * POWEROFF_PRIO_DEFAULT: Use this for generic handler. * * POWEROFF_PRIO_HIGH: Use this if you have multiple handlers and * this handler has higher priority than the * default handler. * * POWEROFF_PRIO_FIRMWARE: Use this if handler uses firmware call. * Has highest priority since firmware is expected * to know best how to power-off hardware properly. */