From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2244DECE58E for ; Thu, 17 Oct 2019 18:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1A2221835 for ; Thu, 17 Oct 2019 18:36:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UHG/4bLF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438937AbfJQSgB (ORCPT ); Thu, 17 Oct 2019 14:36:01 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33263 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438924AbfJQSgB (ORCPT ); Thu, 17 Oct 2019 14:36:01 -0400 Received: by mail-wr1-f66.google.com with SMTP id b9so3520070wrs.0; Thu, 17 Oct 2019 11:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=L/172PFesHWuvzNopt4c4XlSQQptfEWlNlsUsPCP8v8=; b=UHG/4bLFtFCzmfzkVGc2ImqhRoK5hPPugYe10a7h/AHV34r//c3q8LQl4Uj67cTlbN JoCk/UwGu+U8SRK2B1kbvqi4b1zjVtdw6qbWArTZsOG4XLgW34gTamVTiIoRw5JfAow7 o/7y+KYslgzzN/Vs8xkqNYoxXo8S98QVbnQry/NnNc9kdsybo+1TqjbpWc0156S9NjE/ QPp2znoHrt5f62rqIbsgH6NkXL6su3ENXfz9DmK8TQPazqy72sTIaisWe50NqX5JsEg6 Hfd4PuerKUUD/Pf5A8rdUty3wYr1lW+daPacXsvGVJ3/aOUhHtCLAFGlp46QbmB+a3GN IFjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L/172PFesHWuvzNopt4c4XlSQQptfEWlNlsUsPCP8v8=; b=HiYL7h45vzGsQQ3790sHprLwSnZM/+wG3N+7iJSNRrO+II9lFf/fWFd5wKAv0bOEvA zPQX+373akAhichskeG3maRRTGb92xUTkN0nrJyq2AyJJczih0YYN5SXY5/sUdWKhHei rMRthONEUu17OT8iXNUlW5Cznt9pt1ZENiiVFIRUt2sAQ6qRPFDF+f1hN6u+nNwpEyvX bxJ/3epNx1FNJ6RKimUy9vQTJvV9GsJGxsUt4HO3kSxOk9T/7Z3CEy6rj6FnmYeraOGO I/wmEK/oghptcEd6BDcwAsHwKh/HlF5oLKQfglP9HghVx9QK99HdU1ZxUl+R0nuDzepm R+aA== X-Gm-Message-State: APjAAAWPEaylYRwu4IygTC1S+/BKDsDL21ATcUbm+I9+eLxIcOpLrswD fbjBZaLFA8HF8Bmkd69dj3qDTTDf X-Google-Smtp-Source: APXvYqxnhdYQusvYfFeUZHFuap0s7BvTLgqmJZXqKtYnH7Ct6SqR++6A5hhIRnW3QcZVratWlK/KXQ== X-Received: by 2002:adf:ee81:: with SMTP id b1mr3923610wro.58.1571337358592; Thu, 17 Oct 2019 11:35:58 -0700 (PDT) Received: from [10.230.29.119] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id a14sm2540026wmm.44.2019.10.17.11.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2019 11:35:57 -0700 (PDT) Subject: Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch To: Oleksij Rempel , Andrew Lunn , Chris Snook , James Hogan , Jay Cliburn , Mark Rutland , Paul Burton , Ralf Baechle , Rob Herring , Russell King , Vivien Didelot Cc: Pengutronix Kernel Team , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org References: <20191014061549.3669-1-o.rempel@pengutronix.de> <20191014061549.3669-5-o.rempel@pengutronix.de> From: Florian Fainelli Message-ID: <2ad26bdc-e099-ded6-1337-5793aba0958d@gmail.com> Date: Thu, 17 Oct 2019 11:35:48 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191014061549.3669-5-o.rempel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 10/13/2019 11:15 PM, Oleksij Rempel wrote: > Provide basic support for Atheros AR9331 build-in switch. So far it > works as port multiplexer without any hardware offloading support. I glanced through the functional parts of the code, and it looks pretty straight forward, since there is no offloading done so far, do you plan on adding bridge offload eventually if nothing more? When you submit v2, I would suggest splitting the tagger code from the switch driver code, just to make them easier to review. Thanks! -- Florian