From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7ACC7EE25 for ; Thu, 8 Jun 2023 17:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236852AbjFHRTZ (ORCPT ); Thu, 8 Jun 2023 13:19:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236294AbjFHRTX (ORCPT ); Thu, 8 Jun 2023 13:19:23 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 144F12D52; Thu, 8 Jun 2023 10:19:19 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 869151424; Thu, 8 Jun 2023 19:18:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686244727; bh=QCp8g9xbRRzi5prPR0P8JsS2fOCtTw24NgdzRtNAQkA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ivurqXuacySqj7S5bBj29CW1kOJEhzPVX1wUbbe7JjGtmaeDnNDrp9ES7xz5sou7/ 9SxWEvF253nRIvAd0xO3RIxe1NHh8UBjYsr6TpHlRJXbv0I3E64FJ/IqZp0bSQeO4O iBcyUJnbVzHVylvQf0/AKIbigSnsRT2cigQiHQWY= Message-ID: <2b8ccac8-2828-1279-93aa-a601d8d72e43@ideasonboard.com> Date: Thu, 8 Jun 2023 20:19:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 00/53] drm: Convert to platform remove callback returning void Content-Language: en-US To: Laurent Pinchart , Doug Anderson Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Liviu Dudau , Mihail Atanassov , Brian Starkey , David Airlie , Daniel Vetter , Russell King , Joel Stanley , Sam Ravnborg , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrzej Hajda , Neil Armstrong , Robert Foss , Rahul T R , Jayshri Pawar , Liu Ying , Shawn Guo , Sascha Hauer , Minghao Chi , Mark Brown , Kuninori Morimoto , Lucas Stach , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Jingoo Han , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Jani Nikula , Thomas Zimmermann , Danilo Krummrich , Javier Martinez Canillas , Laurentiu Palcu , Philipp Zabel , Paul Cercueil , Anitha Chrisanthus , Qiang Yu , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Matthias Brugger , Kevin Hilman , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Akhil P Oommen , Ricardo Ribalda , Konrad Dybcio , Johan Hovold , Stephen Boyd , Marijn Suijten , Liu Shixin , Miaoqian Lin , Kuogee Hsieh , Bjorn Andersson , Marek Vasut , Ben Skeggs , Karol Herbst , Lyude Paul , Tomi Valkeinen , Guo Zhengkui , Yuan Can , Arnd Bergmann , Liang He , Thierry Reding , Rob Herring , Kieran Bingham , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Deepak R Varma , Alex Deucher , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Hunter , Maxime Ripard , =?UTF-8?Q?Ma=c3=adra_Canal?= , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Jyri Sarha , Alexey Brodkin , Emma Anholt , Melissa Wen , Hyun Kwon , Michal Simek , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, John Stultz , Alim Akhtar , Fabio Estevam , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, Steven Price , linux-rockchip@lists.infradead.org, Xinwei Kong , Mali DP Maintainers , NXP Linux Team , Russell King , linux-sunxi@lists.linux.dev, Jonas Karlman , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org, Christian Gmeiner , linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, Sean Paul , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-stm32@st-md-mailman.stormreply.com, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Yongqin Liu , freedreno@lists.freedesktop.org References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> <20230601154002.uv2wfatpb7b45duz@pengutronix.de> <20230608162642.GA23400@pendragon.ideasonboard.com> From: Tomi Valkeinen In-Reply-To: <20230608162642.GA23400@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 08/06/2023 19:26, Laurent Pinchart wrote: > Hi Doug, > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: >> On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: >>> On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: >>>> this patch series adapts the platform drivers below drivers/gpu/drm >>>> to use the .remove_new() callback. Compared to the traditional .remove() >>>> callback .remove_new() returns no value. This is a good thing because >>>> the driver core doesn't (and cannot) cope for errors during remove. The >>>> only effect of a non-zero return value in .remove() is that the driver >>>> core emits a warning. The device is removed anyhow and an early return >>>> from .remove() usually yields a resource leak. >>>> >>>> By changing the remove callback to return void driver authors cannot >>>> reasonably (but wrongly) assume any more that there happens some kind of >>>> cleanup later. >>> >>> I wonder if someone would volunteer to add the whole series to >>> drm-misc-next?! >> >> It looks as if Neil applied quite a few of them already, so I looked >> at what was left... >> >> I'm a little hesitant to just apply the whole kit-and-caboodle to >> drm-misc-next since there are specific DRM trees for a bunch of them >> and it would be better if they landed there. ...so I went through all >> the patches that still applied to drm-misc-next, then used >> 'scripts/get_maintainer.pl --scm' to check if they were maintained >> through drm-misc. That still left quite a few patches. I've applied >> those ones and pushed to drm-misc-next: >> >> 71722685cd17 drm/xlnx/zynqmp_dpsub: Convert to platform remove >> callback returning void >> 1ed54a19f3b3 drm/vc4: Convert to platform remove callback returning void >> b957812839f8 drm/v3d: Convert to platform remove callback returning void >> e2fd3192e267 drm/tve200: Convert to platform remove callback returning void >> 84e6da7ad553 drm/tiny: Convert to platform remove callback returning void >> 34cdd1f691ad drm/tidss: Convert to platform remove callback returning void >> d665e3c9d37a drm/sun4i: Convert to platform remove callback returning void >> 0c259ab19146 drm/stm: Convert to platform remove callback returning void >> 9a865e45884a drm/sti: Convert to platform remove callback returning void >> 3c855610840e drm/rockchip: Convert to platform remove callback returning void >> e41977a83b71 drm/panfrost: Convert to platform remove callback returning void >> cef3776d0b5a drm/panel: Convert to platform remove callback returning void >> bd296a594e87 drm/mxsfb: Convert to platform remove callback returning void >> 38ca2d93d323 drm/meson: Convert to platform remove callback returning void >> fd1457d84bae drm/mcde: Convert to platform remove callback returning void >> 41a56a18615c drm/logicvc: Convert to platform remove callback returning void >> 980ec6444372 drm/lima: Convert to platform remove callback returning void >> 82a2c0cc1a22 drm/hisilicon: Convert to platform remove callback returning void >> c3b28b29ac0a drm/fsl-dcu: Convert to platform remove callback returning void >> a118fc6e71f9 drm/atmel-hlcdc: Convert to platform remove callback returning void >> 9a32dd324c46 drm/aspeed: Convert to platform remove callback returning void >> 2c7d291c498c drm/arm/malidp: Convert to platform remove callback returning void >> a920028df679 drm/arm/hdlcd: Convert to platform remove callback returning void >> 1bf3d76a7d15 drm/komeda: Convert to platform remove callback returning void >> >> The following ones appeared to apply to the top of drm-misc-next, but >> I didn't apply them since get_maintainer didn't say they were part of >> drm-misc-next: >> >> drm/tiny: Convert to platform remove callback returning void >> drm/tilcdc: Convert to platform remove callback returning void >> drm/sprd: Convert to platform remove callback returning void >> drm/shmobile: Convert to platform remove callback returning void >> drm/rcar-du: Convert to platform remove callback returning void > > If you don't mind, could you take the rcar-du patch through drm-misc too > ? I don't plan to send another pull request for v6.5. > >> drm/omap: Convert to platform remove callback returning void > > Tomi, should drm/omap moved to being maintained through drm-misc ? Yes. tilcdc, tidss and omapdrm are all maintained through drm-misc. But I guess I need to add something to the MAINTAINERS to make this clear. I'll look at it. Tomi