Re: [PATCH v1 1/3] MIPS: dts: ralink: mt7628a: Fix sysc's compatible property for MT7688

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/06/2025 14:20, Ezra Buehler wrote:
> On Fri, Jun 13, 2025 at 2:11 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> Not sure what you propose here, but just in case: devices need specific
>> compatibles.
> 
> Something like this
> 
> diff --git a/arch/mips/ralink/clk.c b/arch/mips/ralink/clk.c
> index 9db73fcac522..7ce9acec3a01 100644
> --- a/arch/mips/ralink/clk.c
> +++ b/arch/mips/ralink/clk.c
> @@ -48,11 +48,9 @@ static const char *clk_cpu(int *idx)
>                 *idx = 2;
>                 return "ralink,mt7620-sysc";
>         case MT762X_SOC_MT7628AN:
> -               *idx = 1;
> -               return "ralink,mt7628-sysc";
>         case MT762X_SOC_MT7688:
>                 *idx = 1;
> -               return "ralink,mt7688-sysc";
> +               return "ralink,mt7628-sysc";
>         default:
>                 *idx = -1;
>                 return "invalid";
> 
> while leaving mt7628a.dtsi as it is, resolves the issue.
> 
> Is this not an option?
That's not a binding, but driver, so obviously it is fine since you are
not removing it from bindings.

Best regards,
Krzysztof