From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FE5C001B0 for ; Wed, 12 Jul 2023 19:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232531AbjGLTYF (ORCPT ); Wed, 12 Jul 2023 15:24:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjGLTYD (ORCPT ); Wed, 12 Jul 2023 15:24:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B7681FC2; Wed, 12 Jul 2023 12:24:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A0D2618F9; Wed, 12 Jul 2023 19:24:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2E67C433C7; Wed, 12 Jul 2023 19:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689189841; bh=Tfejh8EXB17kdCnKChHCKsENFyCAyHmgokGK8jgx0S4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ntLZbbIa8ui4VLewT/ZWNtkWgRs7MbRiBOhFPmK6XwjRbTD/3kPBu1aqhFZ0rkrTw NoTZi0Izio/rxjoLWBubaj+3vL5lvYukHPTwqzZkAMQJcVh8+LeSyVQRiF6uaWPcM/ zuqSfu4Q9tdtMALob+iDjB+wXeO+wx4IclmprAMk1ovBvhz2Kb6mUBbsrON4ASXRiy LcrKecm8vPG1UI+nVF2Hnnsm4BKqA7ElLyIZzw3R6g6ih439+oVUcyzCdQwNklbbMO NQNR0TgJUV9FeYvO7UXNbntxcy7XKI2L5F9S7YJV8onDbx66b25wYy9gLnXBEh/586 QVl33fuhfdZNQ== Message-ID: <2eeb1271-731a-1a70-4c83-449567452f8f@kernel.org> Date: Wed, 12 Jul 2023 21:22:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev Content-Language: en-US To: Sean Paul , Jani Nikula Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "Pan, Xinhui" , Harry Wentland , Leo Li , Rodrigo Siqueira , Hamza Mahfooz , Javier Martinez Canillas , Guchun Chen , Srinivasan Shanmugam , Evan Quan , Likun Gao , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , David Francis , Hawking Zhang , Graham Sider , Lang Yu , Philip Yang , Yifan Zhang , Tim Huang , Zack Rusin , Sam Ravnborg , xurui , Laurent Pinchart , =?UTF-8?Q?Ma=c3=adra_Canal?= , =?UTF-8?Q?Andr=c3=a9_Almeida?= , Qingqing Zhuo , Aurabindo Pillai , Hersen Wu , Fangzhi Zuo , Stylon Wang , Alan Liu , Wayne Lin , Aaron Liu , Melissa Wen , Bhawanpreet Lakha , David Tadokoro , Wenjing Liu , Jiapeng Chong , Mario Limonciello , Alexey Kodanev , Roman Li , =?UTF-8?Q?Joaqu=c3=adn_Ignacio_Aramend=c3=ada?= , Dave Airlie , Russell King , Liviu Dudau , Joel Stanley , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Inki Dae , Seung-Woo Kim , Kyungmin Park , Stefan Agner , Alison Wang , Patrik Jakobsson , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Xinliang Liu , Tian Tao , Danilo Krummrich , Deepak Rawat , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Lucas De Marchi , Ankit Nautiyal , Andrzej Hajda , Matt Roper , Stanislav Lisovskiy , Radhakrishna Sripada , Hans de Goede , Luca Coelho , Niranjana Vishwanathapura , Kai Vehmanen , Vinod Govindapillai , =?UTF-8?Q?=c5=81ukasz_Bartosik?= , Anusha Srivatsa , Chaitanya Kumar Borah , Uma Shankar , Imre Deak , Mitul Golani , Swati Sharma , =?UTF-8?Q?Jouni_H=c3=b6gander?= , Mika Kahola , =?UTF-8?Q?Jos=c3=a9_Roberto_de_Souza?= , Arun R Murthy , Gustavo Sousa , Khaled Almahallawy , Juha-Pekka Heikkila , Andi Shyti , Nirmoy Das , Fei Yang , Animesh Manna , Deepak R Varma , "Jiri Slaby (SUSE)" , Dmitry Baryshkov , Vandita Kulkarni , Suraj Kandpal , Manasi Navare , Drew Davenport , Laurentiu Palcu , Shawn Guo , Sascha Hauer , Philipp Zabel , Marian Cichy , Dan Carpenter , Paul Cercueil , Anitha Chrisanthus , Edmund Dea , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Rob Clark , Abhinav Kumar , Vinod Polimera , Jiasheng Jiang , Konrad Dybcio , Jessica Zhang , Liu Shixin , Marek Vasut , Ben Skeggs , Karol Herbst , Lyude Paul , Tomi Valkeinen , Emma Anholt , Gerd Hoffmann , Kieran Bingham , Tomi Valkeinen , Wolfram Sang , Geert Uytterhoeven , Biju Das , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jyri Sarha , David Lechner , Kamlesh Gurudasani , Rodrigo Siqueira , Melissa Wen , Oleksandr Andrushchenko , Michal Simek , Haneen Mohammed , linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Yongqin Liu , Alim Akhtar , Marijn Suijten , Fabio Estevam , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rockchip@lists.infradead.org, Xinwei Kong , VMware Graphics Reviewers , NXP Linux Team , spice-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, Gurchetan Singh , Sean Paul , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-mips@vger.kernel.org, Chia-I Wu , linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, John Stultz , freedreno@lists.freedesktop.org, Lucas Stach References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> <87fs5tgpvv.fsf@intel.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 12/07/2023 20:31, Sean Paul wrote: >>> 216 struct drm_device *ddev >>> 234 struct drm_device *drm_dev >>> 611 struct drm_device *drm >>> 4190 struct drm_device *dev >>> >>> This series starts with renaming struct drm_crtc::dev to drm_dev. If >>> it's not only me and others like the result of this effort it should be >>> followed up by adapting the other structs and the individual usages in >>> the different drivers. >> >> I think this is an unnecessary change. In drm, a dev is usually a drm >> device, i.e. struct drm_device *. As shown by the numbers above. >> > > I'd really prefer this patch (series or single) is not accepted. This > will cause problems for everyone cherry-picking patches to a > downstream kernel (LTS or distro tree). I usually wouldn't expect > sympathy here, but the questionable benefit does not outweigh the cost > IM[biased]O. You know, every code cleanup and style adjustment is interfering with backporting. The only argument for a fast-pacing kernel should be whether the developers of this code find it more readable with such cleanup. Best regards, Krzysztof