From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 21 Apr 2017 12:47:47 +0200 (CEST) Received: from fllnx210.ext.ti.com ([198.47.19.17]:36612 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992178AbdDUKrjzKVZy (ORCPT ); Fri, 21 Apr 2017 12:47:39 +0200 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id v3LAlLWd006374; Fri, 21 Apr 2017 05:47:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1492771641; bh=lDK1gRcj9LbC7qlMKjdAp8QzzhxVWRYHYBIzZ9uMw94=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=RpNi80hhW1wQ0PGMYyouii/YmaZHR+ns2T9tf5WsIX23oQGTTB0wnhj82q18N3Rw7 xpCK7GGufBoizBJT24VJyV23XscwCXygSAA1KAXMyJH6j9P901baledPdZXSyjnU+n OPPBq+g23MrvRE0tUyeYRXod2a8pETP8WFupYrPQ= Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v3LAlLAb004785; Fri, 21 Apr 2017 05:47:21 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.294.0; Fri, 21 Apr 2017 05:47:20 -0500 Received: from [172.24.190.171] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v3LAlGls031388; Fri, 21 Apr 2017 05:47:17 -0500 Subject: Re: next/master build: 206 builds: 2 failed, 204 passed, 9 errors, 10 warnings (next-20170420) To: Arnd Bergmann , "kernelci.org bot" References: <58f869bd.84a0df0a.dc1f9.4547@mx.google.com> CC: , "Steven J. Hill" , David Daney , , Al Viro , Ulf Hansson , Kevin Hilman , Marc Zyngier From: Sekhar Nori Message-ID: <34ef293f-dc8b-5ab8-8130-90f723089e45@ti.com> Date: Fri, 21 Apr 2017 16:17:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 57754 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: nsekhar@ti.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Arnd, On Thursday 20 April 2017 02:53 PM, Arnd Bergmann wrote: >> davinci_all_defconfig (arm) — PASS, 0 errors, 0 warnings, 0 section >> mismatches >> >> Section mismatches: >> WARNING: modpost: Found 1 section mismatch(es). >> WARNING: modpost: Found 1 section mismatch(es). > The 'section mismatches' detection in kernelci appears to be broken, so we > don't actually see what happened. I can't reproduce it at the moment, > so it's likely that this is fixed by an older patch of mine: I cannot reproduce this as well. > > commit aae89d7dddb831aece31997cdc1c5014fb5a51c1 > Author: Arnd Bergmann > Date: Sat Oct 10 21:19:48 2015 +0200 > > [WRONG] davinci_mmc: remove incorrect __exit annotation > > WARNING: drivers/built-in.o(.exit.text+0x28ec): Section mismatch > in reference from the function davinci_mmcsd_remove() to the function > .init.text:davinci_release_dma_channels() > The function __exit davinci_mmcsd_remove() references > a function __init davinci_release_dma_channels(). > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __init annotation of > davinci_release_dma_channels() so it may be used outside an init section. > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index 621ce47e0e4a..9758d42f19a1 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c > @@ -496,7 +496,7 @@ static int mmc_davinci_start_dma_transfer(struct > mmc_davinci_host *host, > return ret; > } > > -static void __init_or_module > +static void > davinci_release_dma_channels(struct mmc_davinci_host *host) > { > if (!host->use_dma) > @@ -1361,7 +1361,7 @@ static int __init davinci_mmcsd_probe(struct > platform_device *pdev) > return ret; > } > > -static int __exit davinci_mmcsd_remove(struct platform_device *pdev) > +static int davinci_mmcsd_remove(struct platform_device *pdev) > { > struct mmc_davinci_host *host = platform_get_drvdata(pdev); > > @@ -1414,7 +1414,7 @@ static struct platform_driver davinci_mmcsd_driver = { > .pm = davinci_mmcsd_pm_ops, > .of_match_table = davinci_mmc_dt_ids, > }, > - .remove = __exit_p(davinci_mmcsd_remove), > + .remove = davinci_mmcsd_remove, > .id_table = davinci_mmc_devtype, > }; > > This is a very old patch and I don't remember why I never submitted > it or marked it as [WRONG], and I don't see why it only now showed > up in kernelci. I quite don't see how the existing code is wrong. davinci_release_dma_channels() is marked __init_or_module and is accessed in the .remove() routine. If modules are enabled, davinci_release_dma_channels() is available at the time of module removal since __init_or_module evaluates to nothing. And if modules are disabled, then davinci_release_dma_channels() is marked as __init but davinci_mmcsd_remove() is never called. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllnx210.ext.ti.com ([198.47.19.17]:36612 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992178AbdDUKrjzKVZy (ORCPT ); Fri, 21 Apr 2017 12:47:39 +0200 Subject: Re: next/master build: 206 builds: 2 failed, 204 passed, 9 errors, 10 warnings (next-20170420) References: <58f869bd.84a0df0a.dc1f9.4547@mx.google.com> From: Sekhar Nori Message-ID: <34ef293f-dc8b-5ab8-8130-90f723089e45@ti.com> Date: Fri, 21 Apr 2017 16:17:15 +0530 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Arnd Bergmann , "kernelci.org bot" Cc: kernel-build-reports@lists.linaro.org, "Steven J. Hill" , David Daney , linux-mips@linux-mips.org, Al Viro , Ulf Hansson , Kevin Hilman , Marc Zyngier Message-ID: <20170421104715.EjlVUxygENaqC0OGL_nRdIctsdAxeOeU30f1YWegiAE@z> Hi Arnd, On Thursday 20 April 2017 02:53 PM, Arnd Bergmann wrote: >> davinci_all_defconfig (arm) — PASS, 0 errors, 0 warnings, 0 section >> mismatches >> >> Section mismatches: >> WARNING: modpost: Found 1 section mismatch(es). >> WARNING: modpost: Found 1 section mismatch(es). > The 'section mismatches' detection in kernelci appears to be broken, so we > don't actually see what happened. I can't reproduce it at the moment, > so it's likely that this is fixed by an older patch of mine: I cannot reproduce this as well. > > commit aae89d7dddb831aece31997cdc1c5014fb5a51c1 > Author: Arnd Bergmann > Date: Sat Oct 10 21:19:48 2015 +0200 > > [WRONG] davinci_mmc: remove incorrect __exit annotation > > WARNING: drivers/built-in.o(.exit.text+0x28ec): Section mismatch > in reference from the function davinci_mmcsd_remove() to the function > .init.text:davinci_release_dma_channels() > The function __exit davinci_mmcsd_remove() references > a function __init davinci_release_dma_channels(). > This is often seen when error handling in the exit function > uses functionality in the init path. > The fix is often to remove the __init annotation of > davinci_release_dma_channels() so it may be used outside an init section. > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index 621ce47e0e4a..9758d42f19a1 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c > @@ -496,7 +496,7 @@ static int mmc_davinci_start_dma_transfer(struct > mmc_davinci_host *host, > return ret; > } > > -static void __init_or_module > +static void > davinci_release_dma_channels(struct mmc_davinci_host *host) > { > if (!host->use_dma) > @@ -1361,7 +1361,7 @@ static int __init davinci_mmcsd_probe(struct > platform_device *pdev) > return ret; > } > > -static int __exit davinci_mmcsd_remove(struct platform_device *pdev) > +static int davinci_mmcsd_remove(struct platform_device *pdev) > { > struct mmc_davinci_host *host = platform_get_drvdata(pdev); > > @@ -1414,7 +1414,7 @@ static struct platform_driver davinci_mmcsd_driver = { > .pm = davinci_mmcsd_pm_ops, > .of_match_table = davinci_mmc_dt_ids, > }, > - .remove = __exit_p(davinci_mmcsd_remove), > + .remove = davinci_mmcsd_remove, > .id_table = davinci_mmc_devtype, > }; > > This is a very old patch and I don't remember why I never submitted > it or marked it as [WRONG], and I don't see why it only now showed > up in kernelci. I quite don't see how the existing code is wrong. davinci_release_dma_channels() is marked __init_or_module and is accessed in the .remove() routine. If modules are enabled, davinci_release_dma_channels() is available at the time of module removal since __init_or_module evaluates to nothing. And if modules are disabled, then davinci_release_dma_channels() is marked as __init but davinci_mmcsd_remove() is never called. Thanks, Sekhar