Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Dan Aizenstros <dan@vcubed.com>
To: "linux-mips@oss.sgi.com" <linux-mips@oss.sgi.com>
Subject: Error in set_cp0_ functions
Date: Mon, 12 Mar 2001 12:51:53 -0500	[thread overview]
Message-ID: <3AAD0CB9.FAE7C050@vcubed.com> (raw)

Hello All,

There appears to be an error in the new set_cp0_ functions in
the mipsregs.h file.

#define __BUILD_SET_CP0(name,register)                          \
extern __inline__ unsigned int                                  \
set_cp0_##name(unsigned int set)                                \
{                                                               \
        unsigned int res;                                       \
                                                                \
        res = read_32bit_cp0_register(register);                \
        res |= ~set;                                            \
        write_32bit_cp0_register(register, res);                \
                                                                \
        return res;                                             \
}                                                               \

The line
	res |= ~set;
will set every bit except the bit you want to set.

It should be changed to
	res |= set;

Also in the mipsregs.h file the line

#define ST0_UM                 <1   <<  4)

should probably be

#define ST0_UM                 (1   <<  4)

I hope this helps.

Dan Aizenstros
Software Engineer
V3 Semiconductor Corp.

             reply	other threads:[~2001-03-12 17:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-12 17:51 Dan Aizenstros [this message]
2001-03-12 19:43 ` Error in set_cp0_ functions Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AAD0CB9.FAE7C050@vcubed.com \
    --to=dan@vcubed.com \
    --cc=linux-mips@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox