From: Jun Sun <jsun@mvista.com>
To: Daniel Jacobowitz <dan@debian.org>
Cc: Simon Gee <simong@oz.agile.tv>,
linux-mips@oss.sgi.com, gcc-bugs@gcc.gnu.org
Subject: Re: MIPS, profiling, and not working
Date: Tue, 14 Aug 2001 17:11:14 -0700 [thread overview]
Message-ID: <3B79BE22.F679A3D@mvista.com> (raw)
In-Reply-To: 20010814164438.A22825@nevyn.them.org
Daniel Jacobowitz wrote:
>
> On Wed, Aug 15, 2001 at 09:53:20AM +1000, Simon Gee wrote:
> > >
> > > .set noreorder
> > > .set noat
> > > move $1,$31 # save current return address
> > > jal _mcount
> > > subu $sp,$sp,8 # _mcount pops 2 words from stack
> > > .set reorder
> > > .set at
> > >
> >
> > Given this assembler sequence, which is produced by:
> >
> > /* Output assembler code to FILE to increment profiler label # LABELNO
> > for profiling a function entry. */
> >
> > #define FUNCTION_PROFILER(FILE, LABELNO) \
> > { \
> > if (TARGET_MIPS16) \
> > sorry ("mips16 function profiling"); \
> > fprintf (FILE, "\t.set\tnoreorder\n"); \
> > fprintf (FILE, "\t.set\tnoat\n"); \
> > fprintf (FILE, "\tmove\t%s,%s\t\t# save current return address\n", \
> > reg_names[GP_REG_FIRST + 1], reg_names[GP_REG_FIRST + 31]); \
> > fprintf (FILE, "\tjal\t_mcount\n"); \
> > fprintf (FILE, \
> > "\t%s\t%s,%s,%d\t\t# _mcount pops 2 words from stack\n", \
> > TARGET_64BIT ? "dsubu" : "subu", \
> > reg_names[STACK_POINTER_REGNUM], \
> > reg_names[STACK_POINTER_REGNUM], \
> > Pmode == DImode ? 16 : 8); \
> > fprintf (FILE, "\t.set\treorder\n"); \
> > fprintf (FILE, "\t.set\tat\n"); \
> > }
> >
> > in mips.h, wouldn't the positioning of "subu $sp,$sp,8" imply that it was
> > intended to be within "jal"'s delay slot (the expansion of jal is really
> > annoying!) ? This being the case, the stack adjustment may have had to have
> > been made before the call to _mcount is made.
>
> *sigh* Yes, I think the adjustment was meant to be made before the
> call. Perhaps binutils should warn about things in the "delay slot" of a
> macro?
>
It is a reasonable warning if we are in "noreorder" state. Programmers tend
to make assumptions about the delay slot after they do "set .noreorder".
Jun
next prev parent reply other threads:[~2001-08-15 0:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-14 22:09 MIPS, profiling, and not working Daniel Jacobowitz
2001-08-14 23:53 ` Simon Gee
2001-08-14 23:44 ` Daniel Jacobowitz
2001-08-15 0:11 ` Jun Sun [this message]
2001-08-16 10:12 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B79BE22.F679A3D@mvista.com \
--to=jsun@mvista.com \
--cc=dan@debian.org \
--cc=gcc-bugs@gcc.gnu.org \
--cc=linux-mips@oss.sgi.com \
--cc=simong@oz.agile.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox