Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Jun Sun <jsun@mvista.com>
To: Ralf Baechle <ralf@oss.sgi.com>
Cc: Matthew Dharm <mdharm@momenco.com>, Linux-MIPS <linux-mips@oss.sgi.com>
Subject: Re: set_io_port_base()?
Date: Wed, 20 Feb 2002 18:27:23 -0800	[thread overview]
Message-ID: <3C745B0B.84203D3F@mvista.com> (raw)
In-Reply-To: 20020221031338.A31129@dea.linux-mips.net

Ralf Baechle wrote:
> 
> On Wed, Feb 20, 2002 at 06:05:21PM -0800, Matthew Dharm wrote:
> 
> > If it works as I think it does, then is the code in
> > linux/arch/mips/gt64120/momenco_ocelot/setup.c correct?  Specifically,
> > it calls ioremap() and then calls set_io_port_base() with a very
> > strange value -- it's the value from ioremap()
> 
> > modified by the I/O physical address base...
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> I was reading too fast and missed that part.
> 
> > That doesn't look right to me... or I just don't quite understand how
> > this is supposed to work.
> 
> That's definately looks fishy. 

This is actually right.  This way if you pass an virtual at (mips_io_port_base
+ delta), you will get a physical address (GT_PCI_IO_BASE + delta), the
desired place.

Most boards don't need this funky ioremap() and base addr substraction trick,
but ocelot has the IO address placed beyond normal kseg1 addressing range.

Jun

  reply	other threads:[~2002-02-21  3:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-21  1:36 set_io_port_base()? Matthew Dharm
2002-02-21  1:57 ` set_io_port_base()? Ralf Baechle
2002-02-21  2:05   ` set_io_port_base()? Matthew Dharm
2002-02-21  2:13     ` set_io_port_base()? Ralf Baechle
2002-02-21  2:27       ` Jun Sun [this message]
2002-02-21  2:48         ` set_io_port_base()? Matthew Dharm
2002-02-21  2:48           ` set_io_port_base()? Matthew Dharm
2002-02-21  3:03           ` set_io_port_base()? Jason Gunthorpe
2002-02-21  5:35           ` set_io_port_base()? Jun Sun
2002-02-21  3:30         ` set_io_port_base()? Ralf Baechle
2002-02-21 16:34         ` pthread support in mipsel-linux Wayne Gowcher
2002-02-21 17:55           ` H . J . Lu
2002-02-21 18:12             ` Wayne Gowcher
2002-02-21 18:25               ` H . J . Lu
2002-02-21 18:45                 ` Wayne Gowcher
2002-02-22  8:52                   ` Florian Lohoff
2002-02-22 13:38                 ` Maciej W. Rozycki
2002-02-22 13:45                   ` Hiroyuki Machida
2002-02-22 14:28                     ` Maciej W. Rozycki
2002-02-22 16:53                   ` H . J . Lu
2002-02-22 16:57                     ` H . J . Lu
2002-02-22 17:06                     ` Maciej W. Rozycki
2002-02-22 17:14                       ` H . J . Lu
2002-04-19 17:06             ` Equivalent of ioperm / iopl in linux mips ? Wayne Gowcher
2002-04-20  9:03               ` Geert Uytterhoeven
2002-04-22 11:35                 ` Maciej W. Rozycki
2002-04-22 14:55                   ` Geert Uytterhoeven
2002-04-22 15:30                     ` Maciej W. Rozycki
2002-04-22 15:33                       ` Geert Uytterhoeven
2002-04-22 17:44                       ` Ralf Baechle
2002-04-22 18:01                         ` Maciej W. Rozycki
2002-02-21  2:08   ` set_io_port_base()? Matthew Dharm
2002-02-21  2:16     ` set_io_port_base()? Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C745B0B.84203D3F@mvista.com \
    --to=jsun@mvista.com \
    --cc=linux-mips@oss.sgi.com \
    --cc=mdharm@momenco.com \
    --cc=ralf@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox