From: "Gleb O. Raiko" <raiko@niisi.msk.ru>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Ralf Baechle <ralf@uni-koblenz.de>,
linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: [patch] linux: mb() and friends again
Date: Tue, 04 Jun 2002 15:42:08 +0400 [thread overview]
Message-ID: <3CFCA790.9C698A6D@niisi.msk.ru> (raw)
In-Reply-To: Pine.GSO.3.96.1020603182621.14451E-100000@delta.ds2.pg.gda.pl
Maciej,
In previous version of your patch there was the change in mm/c-r3k.c:
static void r3k_dma_cache_wback_inv(unsigned long start, unsigned long
size)
{
- wbflush();
+ iob();
r3k_flush_dcache_range(start, start + size);
}
Why did you drop it? It's definetely required.
While you patch operates in unusual terms from hw point of view, it does
right thins by stating that external wbs do differ from internal wb.
Regards,
Gleb.
Ah. The patch shall be applied, certainly.
next prev parent reply other threads:[~2002-06-04 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-03 16:45 [patch] linux: mb() and friends again Maciej W. Rozycki
2002-06-04 11:42 ` Gleb O. Raiko [this message]
2002-06-04 14:52 ` Maciej W. Rozycki
2002-06-04 17:44 ` Gleb O. Raiko
2002-06-04 18:55 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CFCA790.9C698A6D@niisi.msk.ru \
--to=raiko@niisi.msk.ru \
--cc=linux-mips@fnet.fr \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
--cc=ralf@uni-koblenz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox