From: "Kip Walker" <kwalker@broadcom.com>
To: linux-mips@linux-mips.org
Subject: ELF32 problem in mips64 kernel
Date: Wed, 18 Sep 2002 14:29:06 -0700 [thread overview]
Message-ID: <3D88F022.E414C40F@broadcom.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
There is a faulty check in include/asm-mips64/elf.h:
in elf_check_arch, the following access to the "e_flags" field is
non-sensical if the binary is ELFCLASS32, because "__h" is typed as an
elf64_hdr (through the elfhdr #define), whose e_flags is in a different
location from an elf32_hdr.
if ((__h->e_ident[EI_CLASS] == ELFCLASS32) && \
((__h->e_flags & EF_MIPS_ABI2) == 0)) \
__res = 0; \
Should the n32 check (is this what the EF_MIPS_ABI2 check is about?) be
punted to another binary format handler? The attached patch removed the
ABI2 check.
Kip
[-- Attachment #2: elf.patch --]
[-- Type: text/plain, Size: 841 bytes --]
Index: include/asm-mips64/elf.h
===================================================================
RCS file: /cvs/linux/include/asm-mips64/elf.h,v
retrieving revision 1.10.2.2
diff -u -r1.10.2.2 elf.h
--- include/asm-mips64/elf.h 2002/08/20 18:42:37 1.10.2.2
+++ include/asm-mips64/elf.h 2002/09/18 21:19:42
@@ -43,8 +43,7 @@
\
if (__h->e_machine != EM_MIPS) \
__res = 0; \
- if ((__h->e_ident[EI_CLASS] == ELFCLASS32) && \
- ((__h->e_flags & EF_MIPS_ABI2) == 0)) \
+ if (__h->e_ident[EI_CLASS] == ELFCLASS32) \
__res = 0; \
\
__res; \
@@ -53,7 +52,8 @@
/*
* These are used to set parameters in the core dumps.
*/
-#define ELF_CLASS ELFCLASS64
+//#define ELF_CLASS ELFCLASS64
+#define ELF_CLASS ELFCLASS32
#ifdef __MIPSEB__
#define ELF_DATA ELFDATA2MSB
#elif __MIPSEL__
next reply other threads:[~2002-09-18 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 21:29 Kip Walker [this message]
2002-09-18 21:32 ` ELF32 problem in mips64 kernel Kip Walker
2002-09-20 12:30 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D88F022.E414C40F@broadcom.com \
--to=kwalker@broadcom.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox