From: Jeff Garzik <jgarzik@pobox.com>
To: Carsten Langgaard <carstenl@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, tsbogend@alpha.franken.de,
linux-net@vger.kernel.org, kevink@mips.com
Subject: Re: BUG in the PCNET32 ethernet driver
Date: Wed, 13 Nov 2002 11:42:35 -0500 [thread overview]
Message-ID: <3DD280FB.7070907@pobox.com> (raw)
In-Reply-To: <3DD254F8.14DE20EA@mips.com>
Carsten Langgaard wrote:
> @@ -1316,13 +1316,13 @@
> if ((newskb = dev_alloc_skb (PKT_BUF_SZ))) {
> skb_reserve (newskb, 2);
> skb = lp->rx_skbuff[entry];
> - pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], skb->len,
> PCI_DMA_FROMDEVICE);
> + pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], pkt_len +2,
> PCI_DMA_FROMDEVICE);
> skb_put (skb, pkt_len);
> lp->rx_skbuff[entry] = newskb;
Why does this line not reference PKT_BUF_SZ when all the others do?
next prev parent reply other threads:[~2002-11-13 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-13 13:34 BUG in the PCNET32 ethernet driver Carsten Langgaard
2002-11-13 16:42 ` Jeff Garzik [this message]
2002-11-13 20:08 ` Carsten Langgaard
2002-11-14 4:11 ` David S. Miller
2002-11-13 20:20 ` Jeff Garzik
2002-11-13 20:46 ` Carsten Langgaard
2002-12-11 12:37 ` Carsten Langgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD280FB.7070907@pobox.com \
--to=jgarzik@pobox.com \
--cc=carstenl@mips.com \
--cc=kevink@mips.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-net@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox