From: "Steven J. Hill" <sjhill@realitydiluted.com>
To: linux-mips@linux-mips.org
Subject: Proposed patch for MIPS PCI autoscanning code...
Date: Mon, 24 Mar 2003 11:00:52 -0500 [thread overview]
Message-ID: <3E7F2BB4.8060108@realitydiluted.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
In the PCI autoscanning code for MIPS the assumption is made that the
generic 'pci_read_XXX' and 'pci_write_XXX' will suffice when initially
autoscanning the bus. These functions are defined in the main top-level
PCI code. For one of my platforms, this simply does not hold since the
platform specific PCI functions defined in the 'pci_ops' structure for
the 'mips_pci_channel' need to be used. I propose the following patch
to fix this. Comments before I apply this?
-Steve
[-- Attachment #2: pci_channel.h.diff --]
[-- Type: text/plain, Size: 603 bytes --]
--- pci_channel.h 2001-08-18 10:19:34.000000000 -0400
+++ pci_channel.h.new 2003-03-24 10:54:29.000000000 -0500
@@ -11,12 +11,13 @@
#include <linux/pci.h>
/*
- * Each pci channel is a top-level PCI bus seem by CPU. A machine with
+ * Each pci channel is a top-level PCI bus seen by CPU. A machine with
* multiple PCI channels may have multiple PCI host controllers or a
* single controller supporting multiple channels.
*/
struct pci_channel {
struct pci_ops *pci_ops;
+ struct pci_ops *early_pci_ops;
struct resource *io_resource;
struct resource *mem_resource;
int first_devfn;
[-- Attachment #3: pci_auto.c.diff --]
[-- Type: text/plain, Size: 711 bytes --]
--- pci_auto.c 2001-11-26 20:07:06.000000000 -0500
+++ pci_auto.c.new 2003-03-24 10:54:14.000000000 -0500
@@ -74,9 +74,14 @@
int early_##rw##_config_##size(struct pci_channel *hose, \
int top_bus, int bus, int devfn, int offset, type value) \
{ \
- return pci_##rw##_config_##size( \
- fake_pci_dev(hose, top_bus, bus, devfn), \
- offset, value); \
+ if (hose->early_pci_ops->rw##_##size != NULL) \
+ return hose->early_pci_ops->rw##_##size( \
+ fake_pci_dev(hose, top_bus, bus, devfn), \
+ offset, value); \
+ else \
+ return pci_##rw##_config_##size( \
+ fake_pci_dev(hose, top_bus, bus, devfn), \
+ offset, value); \
}
EARLY_PCI_OP(read, byte, u8 *)
next reply other threads:[~2003-03-24 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-24 16:00 Steven J. Hill [this message]
2003-03-24 18:08 ` Proposed patch for MIPS PCI autoscanning code Jun Sun
2003-03-24 19:39 ` Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E7F2BB4.8060108@realitydiluted.com \
--to=sjhill@realitydiluted.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox