From: "Kip Walker" <kwalker@broadcom.com>
To: "Hartvig Ekner" <hartvig@ekner.info>
Cc: "Linux MIPS mailing list" <linux-mips@linux-mips.org>
Subject: Re: Patch to include/asm-mips/processor.h
Date: Mon, 07 Apr 2003 15:07:29 -0700 [thread overview]
Message-ID: <3E91F6A1.4080AF05@broadcom.com> (raw)
In-Reply-To: 3E917AA1.13694D03@ekner.info
Hartvig Ekner wrote:
>
> I have no idea whether what I did was correct, but at least it is no less incorrect than the code currently
> in there, which coredumps now for some reason (I wonder why it never crashed before). The test-bit macro
> expects a bit-number, and not a mask which it is given in the current code.
>
> So while fixing this, I also used the normal cpu_data macro for the cpu_has_watch() macro, instead of
> looking at CPU(0).
>
> /Hartvig
The second argument to test_bit ought to have been an address, not a
value. Why didn't this crash before? I just ran into it too...
Kip
next prev parent reply other threads:[~2003-04-07 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 13:18 Patch to include/asm-mips/processor.h Hartvig Ekner
2003-04-07 22:07 ` Kip Walker [this message]
2003-04-09 1:16 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E91F6A1.4080AF05@broadcom.com \
--to=kwalker@broadcom.com \
--cc=hartvig@ekner.info \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox