From: "Steven J. Hill" <sjhill@realitydiluted.com>
To: Manish Lachwani <mlachwani@mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Avoid compile warnings on Sibyte using 2.6.10-rc3
Date: Wed, 15 Dec 2004 21:49:15 -0600 [thread overview]
Message-ID: <41C105BB.9020402@realitydiluted.com> (raw)
In-Reply-To: <41C100CB.2070000@mvista.com>
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
Manish Lachwani wrote:
>
> When did you last sync with CVS? There was a change introduced :
>
Literally 10 minutes ago and I did a fresh compile.
> And if running Sibyte in UP mode, cpu_icache_snoops_remote_store is
> redefined
>
I do not run in UP mode, so that is why I did not see it. I suggest
a different version attached. How does that work for you?
-Steve
[-- Attachment #2: cpu-feature-warn.patch --]
[-- Type: text/x-patch, Size: 741 bytes --]
Index: cpu-features.h
===================================================================
RCS file: /home/cvs/linux/include/asm-mips/cpu-features.h,v
retrieving revision 1.9
diff -u -r1.9 cpu-features.h
--- cpu-features.h 7 Dec 2004 02:08:34 -0000 1.9
+++ cpu-features.h 16 Dec 2004 03:42:03 -0000
@@ -87,13 +87,13 @@
* that did the store so we can't optimize this into only doing the flush on
* the local CPU.
*/
-#ifdef CONFIG_SMP
#ifndef cpu_icache_snoops_remote_store
+#ifdef CONFIG_SMP
#define cpu_icache_snoops_remote_store (cpu_data[0].icache.flags & MIPS_IC_SNOOPS_REMOTE)
-#endif
#else
#define cpu_icache_snoops_remote_store 1
#endif
+#endif
/*
* Certain CPUs may throw bizarre exceptions if not the whole cacheline
next prev parent reply other threads:[~2004-12-16 3:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-15 23:56 [PATCH] Avoid compile warnings on Sibyte using 2.6.10-rc3 Manish Lachwani
2004-12-16 3:11 ` Steven J. Hill
2004-12-16 3:28 ` Manish Lachwani
2004-12-16 3:49 ` Steven J. Hill [this message]
2004-12-16 3:49 ` Manish Lachwani
2004-12-16 3:54 ` Manish Lachwani
2004-12-16 3:57 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C105BB.9020402@realitydiluted.com \
--to=sjhill@realitydiluted.com \
--cc=linux-mips@linux-mips.org \
--cc=mlachwani@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox