From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 16 Dec 2004 03:50:15 +0000 (GMT) Received: from gateway-1237.mvista.com ([IPv6:::ffff:12.44.186.158]:61689 "EHLO hermes.mvista.com") by linux-mips.org with ESMTP id ; Thu, 16 Dec 2004 03:50:09 +0000 Received: from mvista.com (prometheus.mvista.com [10.0.0.139]) by hermes.mvista.com (Postfix) with ESMTP id 321ED1874C; Wed, 15 Dec 2004 19:49:58 -0800 (PST) Message-ID: <41C105E5.4040006@mvista.com> Date: Wed, 15 Dec 2004 19:49:57 -0800 From: Manish Lachwani User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.2) Gecko/20040308 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Steven J. Hill" Cc: linux-mips@linux-mips.org Subject: Re: [PATCH] Avoid compile warnings on Sibyte using 2.6.10-rc3 References: <20041215235632.GA11386@prometheus.mvista.com> <41C0FCFD.9010603@realitydiluted.com> <41C100CB.2070000@mvista.com> <41C105BB.9020402@realitydiluted.com> In-Reply-To: <41C105BB.9020402@realitydiluted.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 6691 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: mlachwani@mvista.com Precedence: bulk X-list: linux-mips Steven J. Hill wrote: > Manish Lachwani wrote: > >> >> When did you last sync with CVS? There was a change introduced : > > Literally 10 minutes ago and I did a fresh compile. > >> And if running Sibyte in UP mode, cpu_icache_snoops_remote_store is >> redefined >> > I do not run in UP mode, so that is why I did not see it. I suggest > a different version attached. How does that work for you? > > -Steve > >------------------------------------------------------------------------ > >Index: cpu-features.h >=================================================================== >RCS file: /home/cvs/linux/include/asm-mips/cpu-features.h,v >retrieving revision 1.9 >diff -u -r1.9 cpu-features.h >--- cpu-features.h 7 Dec 2004 02:08:34 -0000 1.9 >+++ cpu-features.h 16 Dec 2004 03:42:03 -0000 >@@ -87,13 +87,13 @@ > * that did the store so we can't optimize this into only doing the flush on > * the local CPU. > */ >-#ifdef CONFIG_SMP > #ifndef cpu_icache_snoops_remote_store >+#ifdef CONFIG_SMP > #define cpu_icache_snoops_remote_store (cpu_data[0].icache.flags & MIPS_IC_SNOOPS_REMOTE) >-#endif > #else > #define cpu_icache_snoops_remote_store 1 > #endif >+#endif > > /* > * Certain CPUs may throw bizarre exceptions if not the whole cacheline > > Looks good to me Thanks Manish Lachwani