From: Ed Martini <martini@c2micro.com>
To: linux-mips@linux-mips.org
Subject: inconsistent asm macro
Date: Tue, 29 Mar 2005 17:45:13 -0800 [thread overview]
Message-ID: <424A04A9.9060703@c2micro.com> (raw)
In include/asm-mips/interrupt.h, the definition for local_irq_restore is
inconsistent in its use of .reorder/.noreorder assembler directives.
Other asm macros in interrupt.h are wrapped with '.set push' and '.set pop'.
It doesn't seem to be a problem with the 2.96 mipsel-linux- assembler,
but it caused me a problem with my 4.0-based toolchain. (As it was the
local_irq_restore left the assembler in 'reorder' mode and a stack
pointer post-inc was reordered out of the return delay slot where it
belonged.) Luckily we have a sharp compiler guy who figured it out.
Thanks.
As usual, there may be a reason for this, but it took me a whole day to
find it, and I thought I'd point it out.
Ed Martini
$ diff -uN interrupt.h interrupt-new.h
--- interrupt.h 2005-03-29 17:35:02.922362384 -0800
+++ interrupt-new.h 2005-03-29 17:33:26.350770293 -0800
@@ -100,6 +100,7 @@
__asm__ (
".macro\tlocal_irq_restore flags\n\t"
+ ".set\tpush\n\t"
".set\tnoreorder\n\t"
".set\tnoat\n\t"
"mfc0\t$1, $12\n\t"
@@ -109,8 +110,7 @@
"or\t\\flags, $1\n\t"
"mtc0\t\\flags, $12\n\t"
"irq_disable_hazard\n\t"
- ".set\tat\n\t"
- ".set\treorder\n\t"
+ ".set\tpop\n\t"
".endm");
next reply other threads:[~2005-03-30 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-30 1:45 Ed Martini [this message]
2006-01-16 15:59 ` inconsistent asm macro Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=424A04A9.9060703@c2micro.com \
--to=martini@c2micro.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox