From: "Vladimir A. Barinov" <vbarinov@ru.mvista.com>
To: linux-mips@linux-mips.org
Cc: ralf@linux-mips.org, ppopov@embeddedalley.com
Subject: [PATCH] Philips PNX8550 USB Host driver compile fix
Date: Tue, 06 Dec 2005 21:23:52 +0300 [thread overview]
Message-ID: <4395D738.3080800@ru.mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
Hello, Ralf, Pete,
The current ohci-hcd driver is a little defective.
It's unable to use usb-ohci as modules in the case when PCI and on-chip
USB are enabled.
It just will not be compiled since there are two calls if module_init in
ohci-hcd.
Please look at the patch attached.
I 'm not sure is this patch well for this situation.
Any suggestions are very appreciated.
TIA,
Vladimir
[-- Attachment #2: usb_modules.patch --]
[-- Type: text/plain, Size: 828 bytes --]
--- linux-2.6.10.orig/drivers/usb/host/ohci-hcd.c 2005-12-02 16:37:59.000000000 +0300
+++ linux-2.6.10/drivers/usb/host/ohci-hcd.c 2005-12-02 19:34:21.000000000 +0300
@@ -906,8 +906,12 @@ MODULE_LICENSE ("GPL");
#endif
#ifdef CONFIG_PNX8550
+#if defined(CONFIG_PCI) && defined(CONFIG_USB_OHCI_HCD_MODULE)
+#error "unable to compile PNX8550 USB and PCI USB as modules simultaneously until usb hcd stack is rewritten"
+#else
#include "ohci-pnx8550.c"
#endif
+#endif
#ifdef CONFIG_USB_OHCI_HCD_PPC_SOC
#include "ohci-ppc-soc.c"
@@ -919,6 +923,7 @@ MODULE_LICENSE ("GPL");
|| defined (CONFIG_ARCH_LH7A404) \
|| defined (CONFIG_PXA27x) \
|| defined (CONFIG_SOC_AU1X00) \
+ || defined (CONFIG_PNX8550) \
|| defined (CONFIG_USB_OHCI_HCD_PPC_SOC) \
)
#error "missing bus glue for ohci-hcd"
next reply other threads:[~2005-12-06 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 18:23 Vladimir A. Barinov [this message]
2005-12-06 19:35 ` [PATCH] Philips PNX8550 USB Host driver compile fix Peter Popov
2005-12-08 16:51 ` Vladimir A. Barinov
2005-12-09 23:20 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2005-12-06 18:22 Vladimir A. Barinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4395D738.3080800@ru.mvista.com \
--to=vbarinov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=ppopov@embeddedalley.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox