From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] 8250_early console support for au1x00
Date: Thu, 04 May 2006 19:48:47 +0400 [thread overview]
Message-ID: <445A225F.7090300@ru.mvista.com> (raw)
In-Reply-To: <20060504152048.GG19913@gundam.enneenne.com>
Hello.
Rodolfo Giometti wrote:
> On Thu, May 04, 2006 at 06:35:55PM +0400, Sergei Shtylyov wrote:
>> The following 2 fragments are kind of contradictory:
> I see, but I decided to keep it different since the kernel message is:
> Adding console on ttyS0 at MMIO 0x11100000 (options '115200')
> and setting it as:
> Adding console on ttyS0 at AU 0x11100000 (options '115200')
> sounds bad to me. :)
Yes. But the error msg emmitted by your patch would look this way, i.e.
AU, not MMIO. No symmetry. :-)
>>And, as I said. there's not much sense in calling iomap() on Alchemy UART,
>>UPIO_IOREMAP flag wasn't really needed...
>
>
> Mmm... to be «coherent» I think it should be done...
Wouldn't hurt, just useless. So, I think no special checks are needed to
avoid it. :-)
> Ciao,
>
> Rodolfo
WBR, Sergei
next prev parent reply other threads:[~2006-05-04 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 13:45 [PATCH] 8250_early console support for au1x00 Rodolfo Giometti
2006-05-04 14:35 ` Sergei Shtylyov
2006-05-04 15:20 ` Rodolfo Giometti
2006-05-04 15:48 ` Sergei Shtylyov [this message]
2006-05-04 16:33 ` Rodolfo Giometti
2006-05-22 20:50 ` [PATCH] 8250_early console support for au1x00 (again) Rodolfo Giometti
2006-08-28 14:51 ` Sergei Shtylyov
2006-08-30 10:53 ` Rodolfo Giometti
2006-08-30 12:41 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445A225F.7090300@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox