Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Tim Bird <tim.bird@am.sony.com>
To: linux-mips@linux-mips.org
Subject: [PATCH] fix mips/Makefile to support CROSS_COMPILE from environment var
Date: Thu, 04 May 2006 12:35:25 -0700	[thread overview]
Message-ID: <445A577D.7090507@am.sony.com> (raw)

The following patch allows to build using CROSS_COMPILE from the environment.
I have an automated system which works like this, but it chokes on MIPS when
I use it with (albeit non-standard-named) cross-compiler tools.  An easy
workaround I'm using is to put CROSS_COMPILE on the make command line, but it would
be nice to use the definition already in the environment when I work
manually in the system.

For past discussion of this see:
http://www.linux-mips.org/archives/linux-mips/2003-02/msg00196.html

I'm not sure why the change didn't make it in back in 2003, but
if the complaint was about the use of "?=", that seems to be in use
other places, and fairly standard now.

For example, from the top level kernel Makefile:
ARCH            ?= $(SUBARCH)
CROSS_COMPILE   ?=

Signed-off-by: Tim Bird <tim.bird@am.sony.com>

---
--- alp-linux.orig/arch/mips/Makefile	2006-05-04 12:22:17.000000000 -0700
+++ alp-linux/arch/mips/Makefile	2006-05-04 12:10:22.000000000 -0700
@@ -49,7 +49,7 @@ UTS_MACHINE		:= mips64
 endif

 ifdef CONFIG_CROSSCOMPILE
-CROSS_COMPILE		= $(tool-prefix)
+CROSS_COMPILE		?= $(tool-prefix)
 endif

 CHECKFLAGS-y				+= -D__linux__ -D__mips__ \

             reply	other threads:[~2006-05-04 19:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-04 19:35 Tim Bird [this message]
2006-05-04 20:55 ` [PATCH] fix mips/Makefile to support CROSS_COMPILE from environment var Thiemo Seufer
2006-05-04 21:04   ` Tom Rini
2006-05-04 21:25     ` Kevin D. Kissell
2006-05-04 21:25       ` Kevin D. Kissell
2006-05-04 21:32       ` Kevin D. Kissell
2006-05-04 21:32         ` Kevin D. Kissell
2006-05-04 21:44       ` Tom Rini
2006-05-04 23:06     ` Ralf Baechle
2006-05-04 23:14       ` Tom Rini
2006-05-04 23:34         ` Tom Rini
2006-05-05  7:45           ` Geert Uytterhoeven
2006-05-05 18:45             ` Wolfgang Denk
2006-05-08 18:35       ` [PATCH] fix mips/Makefile to support CROSS_COMPILE from envir onment var Tim Bird
2006-05-08 18:56         ` Dan Malek
2006-05-04 21:17   ` [PATCH] fix mips/Makefile to support CROSS_COMPILE from environment var Tim Bird
2006-05-04 22:35     ` Thiemo Seufer
2006-05-08 18:22       ` Tim Bird

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445A577D.7090507@am.sony.com \
    --to=tim.bird@am.sony.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox