From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: vagabon.xyz@gmail.com, linux-mips@linux-mips.org,
ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp
Subject: Re: [PATCH 2/6] setup.c: move initrd code inside dedicated functions
Date: Fri, 11 Aug 2006 17:13:01 +0200 [thread overview]
Message-ID: <44DC9E7D.1000303@innova-card.com> (raw)
In-Reply-To: <20060811.235056.126141886.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> On Wed, 9 Aug 2006 16:52:34 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
>> + unsigned long initrd_size =
>> + (unsigned long)initrd_end - (unsigned long)initrd_start;
>
> While initrd_end and initrd_start are unsigned long, these casts are
> redundant.
>
Absolutely. I don't remember why I added these useless casts...
>> + printk(KERN_INFO "Initial ramdisk at: 0x%p (%lu bytes)\n",
>> + (void *)initrd_start, initrd_size);
>
> You can use "0x%lx" for initrd_start and remove the cast. I know this
> fragment are copied from corrent code as is, but it would be a good
> chance to clean it up.
>
You're right.
I'll change that and make a take #3.
Thanks for your comments.
Franck
next prev parent reply other threads:[~2006-08-11 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 14:52 [patch 0/6] cleanup setup.c (take #2) Franck Bui-Huu
2006-08-09 14:52 ` [PATCH 1/6] setup.c: cleanup bootmem_init() Franck Bui-Huu
2006-08-09 14:52 ` [PATCH 2/6] setup.c: move initrd code inside dedicated functions Franck Bui-Huu
2006-08-11 14:50 ` Atsushi Nemoto
2006-08-11 15:13 ` Franck Bui-Huu [this message]
2006-08-09 14:52 ` [PATCH 3/6] setup.c: remove useless includes Franck Bui-Huu
2006-08-09 14:52 ` [PATCH 4/6] setup.c: do not inline functions Franck Bui-Huu
2006-08-09 14:52 ` [PATCH 5/6] setup.c: remove MAXMEM macro Franck Bui-Huu
2006-08-09 14:52 ` [PATCH 6/6] setup.c: use early_param() for early command line parsing Franck Bui-Huu
2006-08-11 11:55 ` Franck Bui-Huu
-- strict thread matches above, loose matches on Subject: below --
2006-08-11 17:24 [PATCH 2/6] setup.c: move initrd code inside dedicated functions Kaz Kylheku
2006-08-11 17:24 ` Kaz Kylheku
2006-08-13 17:07 ` Geert Uytterhoeven
2006-08-11 15:51 cleanup setup.c (take #3) Franck Bui-Huu
2006-08-11 15:51 ` [PATCH 2/6] setup.c: move initrd code inside dedicated functions Franck Bui-Huu
2006-08-08 12:48 [patch 0/6] cleanup setup.c Franck Bui-Huu
2006-08-08 12:48 ` [PATCH 2/6] setup.c: move initrd code inside dedicated functions Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DC9E7D.1000303@innova-card.com \
--to=vagabon.xyz@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox