From mboxrd@z Thu Jan  1 00:00:00 1970
Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 18 Sep 2006 21:11:13 +0100 (BST)
Received: from h155.mvista.com ([63.81.120.155]:43821 "EHLO imap.sh.mvista.com")
	by ftp.linux-mips.org with ESMTP id S20037885AbWIRULK (ORCPT
	<rfc822;linux-mips@linux-mips.org>); Mon, 18 Sep 2006 21:11:10 +0100
Received: from [192.168.1.248] (unknown [10.150.0.9])
	by imap.sh.mvista.com (Postfix) with ESMTP
	id 7207D3ECD; Mon, 18 Sep 2006 13:10:48 -0700 (PDT)
Message-ID: <450EFDCF.2020400@ru.mvista.com>
Date:	Tue, 19 Sep 2006 00:13:03 +0400
From:	Sergei Shtylyov <sshtylyov@ru.mvista.com>
Organization: MontaVista Software Inc.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
X-Accept-Language: ru, en-us, en-gb
MIME-Version: 1.0
To:	Rodolfo Giometti <giometti@linux.it>
Cc:	linux-mips@linux-mips.org
Subject: Re: [PATCH] au1x00 serial real interrupt
References: <20060522165244.GA16223@enneenne.com> <44FD9587.3030708@ru.mvista.com> <4502ED14.6080506@ru.mvista.com>
In-Reply-To: <4502ED14.6080506@ru.mvista.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Return-Path: <sshtylyov@ru.mvista.com>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 12592
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: sshtylyov@ru.mvista.com
Precedence: bulk
X-list: linux-mips

Hello.

Sergei Shtylyov wrote:

>>> diff --git a/include/asm-mips/serial.h b/include/asm-mips/serial.h
>>> index 7b23664..0197062 100644
>>> --- a/include/asm-mips/serial.h
>>> +++ b/include/asm-mips/serial.h
>>> @@ -11,6 +11,14 @@
>>>  
>>>  #include <linux/config.h>
>>>  
>>> +#ifdef CONFIG_SOC_AU1X00
>>> +/*
>>> + * We have to redefine "is_real_interrupt()" for Au1x00 CPUs...
>>> + */
>>> +#undef is_real_interrupt
>>> +#define is_real_interrupt(irq)    ((irq) != ~0)
>>> +#endif
>>> +
>>>  /*
>>>   * This assumes you have a 1.8432 MHz clock for your UART.
>>>   *

>    Well, after looking at drivers/serial/8250.c a bit more, I think this 
> may be even more simlified since that driver seems to treat the negative 
> values as completely invalid anyway. IOW, we can just:

> #define is_real_interrupt(irq)    1

    Rodolfo, can you do this (possibly adding more elaborate comment about 
UART0 using IRQ0)?

WBR, Sergei