From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, mingo@redhat.com
Subject: Re: [PATCH 2/3] [MIPS] lockdep: add STACKTRACE_SUPPORT and enable LOCKDEP_SUPPORT
Date: Tue, 26 Sep 2006 17:58:12 +0200 [thread overview]
Message-ID: <45194E14.10203@innova-card.com> (raw)
In-Reply-To: <20060926.234401.08077257.anemo@mba.ocn.ne.jp>
Hi Atsushi
Atsushi Nemoto wrote:
> Implement stacktrace interface by using unwind_stack().
> And enable lockdep support.
>
[snip]
> + */
> +static inline void
> +save_raw_context_stack(struct stack_trace *trace, unsigned int skip,
> + unsigned long reg29)
> +{
[snip]
> +
> +static inline struct pt_regs *
> +save_context_stack(struct stack_trace *trace, unsigned int skip,
> + struct task_struct *task, struct pt_regs *regs)
> +{
> + unsigned long sp = regs->regs[29];
Any reasons why marking these 2 functions as inlined ? IMHO gcc is now
good enough for this decision.
Franck
next prev parent reply other threads:[~2006-09-26 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 14:44 [PATCH 2/3] [MIPS] lockdep: add STACKTRACE_SUPPORT and enable LOCKDEP_SUPPORT Atsushi Nemoto
2006-09-26 15:16 ` Atsushi Nemoto
2006-09-28 10:26 ` Atsushi Nemoto
2006-09-28 10:42 ` Ralf Baechle
2006-09-29 9:32 ` Atsushi Nemoto
2006-09-26 15:58 ` Franck Bui-Huu [this message]
2006-09-26 16:11 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45194E14.10203@innova-card.com \
--to=vagabon.xyz@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=mingo@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox