From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH][MIPS] merge a few printk in check_wait()
Date: Wed, 18 Oct 2006 18:00:02 +0200 [thread overview]
Message-ID: <45364F82.8030308@innova-card.com> (raw)
In-Reply-To: <20061019002718.1ca0ec56.yoichi_yuasa@tripeaks.co.jp>
Hi,
Yoichi Yuasa wrote:
> Hi Ralf,
>
> This patch has merged a few printk in check_wait().
>
> Yoichi
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/kernel/cpu-probe.c mips/arch/mips/kernel/cpu-probe.c
> --- mips-orig/arch/mips/kernel/cpu-probe.c 2006-10-18 10:20:24.397574000 +0900
> +++ mips/arch/mips/kernel/cpu-probe.c 2006-10-18 10:28:53.113366750 +0900
> @@ -120,11 +120,9 @@ static inline void check_wait(void)
does it really need to be inlined ?
> case CPU_R3081:
[snip]
> +
> + if (cpu_wait)
> + printk(" available.\n");
> + else
> + printk(" unavailable.\n");
what about:
printk(" %savailable.\n", cpu_wait ? "" : "un");
Franck
next prev parent reply other threads:[~2006-10-18 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 15:27 [PATCH][MIPS] merge a few printk in check_wait() Yoichi Yuasa
2006-10-18 16:00 ` Franck Bui-Huu [this message]
2006-10-18 16:15 ` Ralf Baechle
2006-10-19 8:07 ` Yoichi Yuasa
2006-10-19 16:54 ` Maciej W. Rozycki
2006-10-19 17:48 ` Ralf Baechle
2006-10-19 22:10 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45364F82.8030308@innova-card.com \
--to=vagabon.xyz@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox