From: David Daney <ddaney@avtrex.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] Use "long" for 64-bit values on 64-bit kernel.
Date: Thu, 19 Oct 2006 08:27:45 -0700 [thread overview]
Message-ID: <45379971.6070803@avtrex.com> (raw)
In-Reply-To: <20061019.231645.126573493.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> Just resend again to avoid being obscured by discussion.
>
> This would get rid of some warnings about "long" vs. "long long".
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
> diff --git a/include/asm-mips/addrspace.h b/include/asm-mips/addrspace.h
> index 45c706e..7401711 100644
> --- a/include/asm-mips/addrspace.h
> +++ b/include/asm-mips/addrspace.h
> @@ -19,12 +19,17 @@ #ifdef __ASSEMBLY__
> #define _ATYPE_
> #define _ATYPE32_
> #define _ATYPE64_
> -#define _LLCONST_(x) x
> +#define _CONST64_(x) x
> #else
> #define _ATYPE_ __PTRDIFF_TYPE__
> #define _ATYPE32_ int
> +#ifdef CONFIG_64BIT
> +#define _ATYPE64_ long
> +#define _CONST64_(x) x ## L
> +#else
> #define _ATYPE64_ long long
> -#define _LLCONST_(x) x ## LL
> +#define _CONST64_(x) x ## LL
> +#endif
> #endif
This duplicates the things in asm-mips/types.h. Is there some reason
that we cannot use s64/u64 instead of long/long long?
David Daney.
next prev parent reply other threads:[~2006-10-19 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 14:16 [PATCH] Use "long" for 64-bit values on 64-bit kernel Atsushi Nemoto
2006-10-19 15:27 ` David Daney [this message]
2006-10-20 16:28 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45379971.6070803@avtrex.com \
--to=ddaney@avtrex.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox