From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] add STB810 support (Philips PNX8550-based)
Date: Thu, 07 Dec 2006 18:46:58 +0300 [thread overview]
Message-ID: <45783772.6030504@ru.mvista.com> (raw)
In-Reply-To: <20061207182234.83212939.vitalywool@gmail.com>
Hello.
Vitaly Wool wrote:
> please find the patch that adds support for STB810 below.
[...]
> Signed-off-by: Vitaly Wool <vitalywool@gmail.com>
> Index: linux-mips.git/arch/mips/philips/pnx8550/stb810/board_setup.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-mips.git/arch/mips/philips/pnx8550/stb810/board_setup.c 2006-12-07 18:21:04.000000000 +0300
> @@ -0,0 +1,56 @@
[...]
> +/* CP0 hazard avoidance. */
> +#define BARRIER __asm__ __volatile__(".set noreorder\n\t" \
> + "nop; nop; nop; nop; nop; nop;\n\t" \
> + ".set reorder\n\t")
> +
Erm, barrier code have been reworked, IIRC. Is there really a need for the
6-nop custom barrier here?
> +void __init board_setup(void)
> +{
> + unsigned long config0, configpr;
> +
> + config0 = read_c0_config();
> +
> + /* clear all three cache coherency fields */
> + config0 &= ~(0x7 | (7<<25) | (7<<28));
> + config0 |= (CONF_CM_DEFAULT | (CONF_CM_DEFAULT<<25) |
> + (CONF_CM_DEFAULT<<28));
> + write_c0_config(config0);
> + BARRIER;
> +
> + configpr = read_c0_config7();
> + configpr |= (1<<19); /* enable tlb */
> + write_c0_config7(configpr);
> + BARRIER;
> +}
> Index: linux-mips.git/arch/mips/philips/pnx8550/stb810/irqmap.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-mips.git/arch/mips/philips/pnx8550/stb810/irqmap.c 2006-12-07 18:21:04.000000000 +0300
> @@ -0,0 +1,23 @@
[...]
> +char irq_tab_jbs[][5] __initdata = {
> + [8] = { -1, PNX8550_INT_PCI_INTA, 0xff, 0xff, 0xff},
> + [9] = { -1, PNX8550_INT_PCI_INTA, 0xff, 0xff, 0xff},
> + [10] = { -1, PNX8550_INT_PCI_INTA, 0xff, 0xff, 0xff},
> +};
This is somewhat unusual PCI interrupt rounting...
> Index: linux-mips.git/arch/mips/kernel/head.S
> Index: linux-mips.git/arch/mips/configs/pnx8550-stb810_defconfig
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-mips.git/arch/mips/configs/pnx8550-stb810_defconfig 2006-12-07 18:21:04.000000000 +0300
> @@ -0,0 +1,1777 @@
> +#
> +# Automatically generated make config: don't edit
> +# Linux kernel version: 2.6.19-rc5
> +# Wed Nov 8 13:46:57 2006
> +#
> +CONFIG_ARM=y
ARM?! Are you sure it's a correct defconfig? ;-)
WBR, Sergei
next prev parent reply other threads:[~2006-12-07 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 15:22 [PATCH] add STB810 support (Philips PNX8550-based) Vitaly Wool
2006-12-07 15:46 ` Sergei Shtylyov [this message]
2006-12-07 15:48 ` Ralf Baechle
2006-12-07 20:43 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45783772.6030504@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox