From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE44AEB64DC for ; Mon, 17 Jul 2023 06:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbjGQGGV (ORCPT ); Mon, 17 Jul 2023 02:06:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbjGQGGP (ORCPT ); Mon, 17 Jul 2023 02:06:15 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4DEFE64 for ; Sun, 16 Jul 2023 23:06:13 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b9352ff1aeso18039191fa.1 for ; Sun, 16 Jul 2023 23:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689573972; x=1692165972; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V9PPbgd68wocT4TvRhmcO/nETjGOz62AhMV/Wt93B7Q=; b=ms+Ay07n0lyPm2SMUObQ9GjdsaldYs4VUWpkhI9RsYlip9CudCjC8ofTEhWMxc+gbc K0YtVClyOIFxttDZLliNzf3gbsIu835cEAVjrm05LoLwmD+xEpYYmElER6/tTcPAFvd/ p2lztdzYDwdRIgKoaXXCaQGNTdGxMByqHznLfQzrSXnEnAliyuQIuPJ2DHdt8U8hDVUj pIIVhdinE7fn9LMpO4v4GDRrX6wVNxGYi92lYsJ/m30w58uxf/A8pv9pmFF9oslSdX7C f8TXdN/IpdnuJOIClc5E5kJaWu5AzB+RIbuDksQjbE4lIlj/YHAncSTpNp/lY1qETdK/ eyqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689573972; x=1692165972; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V9PPbgd68wocT4TvRhmcO/nETjGOz62AhMV/Wt93B7Q=; b=UvjkPv3Tmg5lKGYlZabNuxNvrSpZGrytTbJmP+mC7DnBA/KWwSBwJNfCw722E+eb7p QFBe/nEyRBRUsNRaQvSTm1ZljagThY9IQq7cmrO6sNMztSkFbjaCKkCpzekamLe0xTAi hVHEG+SaLE/RnED+mhRFwxp8071VZyvqFQV8EOyi9LH1FRHe19+XGNeDRkqPLVIWd6WG bxeedYqexXozgaKcxn4pgjnFiicLm7Bu5XFnU1lM5oqok7o1/H8RsXNTpzHDbZoIPKAW UnfpDZ/+mDy+GM/WV0EAGlrWnG5k/l+Y9I5Ds2vmQKA0oaXQhN/X5C16H2IG8VvZaJ2h +PJQ== X-Gm-Message-State: ABy/qLa5vRslbllZubGO0Ok5dpJxfUGXTGD4hLWAghfstjxH3BInzxON OkSNGlbHtF8pk2fJN5mmttk0ww== X-Google-Smtp-Source: APBJJlHW/NFDKdvFhoq+y8xrvjg5fcDRitDcC29a/QX354QST/fiAOhwToFZQukWGxzIAoA8z/fnRA== X-Received: by 2002:a05:6512:1181:b0:4fb:7d73:d097 with SMTP id g1-20020a056512118100b004fb7d73d097mr6674575lfr.39.1689573972086; Sun, 16 Jul 2023 23:06:12 -0700 (PDT) Received: from [192.168.69.115] ([176.176.144.39]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4e05000000b003143d80d11dsm18078305wrt.112.2023.07.16.23.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 23:06:11 -0700 (PDT) Message-ID: <45f89fee-6825-3f5d-9dfb-aad5d47c8c36@linaro.org> Date: Mon, 17 Jul 2023 08:06:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 1/8] swiotlb: make io_tlb_default_mem local to swiotlb.c Content-Language: en-US To: Petr Tesarik , Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" Cc: Roberto Sassu , Kefeng Wang , petr@tesarici.cz References: <7f64111986f4f361a2deb4a1a1b6f588e63a851b.1689261692.git.petr.tesarik.ext@huawei.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <7f64111986f4f361a2deb4a1a1b6f588e63a851b.1689261692.git.petr.tesarik.ext@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Petr, On 13/7/23 17:23, Petr Tesarik wrote: > From: Petr Tesarik > > SWIOTLB implementation details should not be exposed to the rest of the > kernel. This will allow to make changes to the implementation without > modifying non-swiotlb code. > > To avoid breaking existing users, provide helper functions for the few > required fields. > > As a bonus, using a helper function to initialize struct device allows to > get rid of an #ifdef in driver core. > > Signed-off-by: Petr Tesarik > --- > arch/arm/xen/mm.c | 2 +- > arch/mips/pci/pci-octeon.c | 2 +- > arch/x86/kernel/pci-dma.c | 2 +- > drivers/base/core.c | 4 +--- > drivers/xen/swiotlb-xen.c | 2 +- > include/linux/swiotlb.h | 25 +++++++++++++++++++++++- > kernel/dma/swiotlb.c | 39 +++++++++++++++++++++++++++++++++++++- > 7 files changed, 67 insertions(+), 9 deletions(-) > diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h > index 4e52cd5e0bdc..07216af59e93 100644 > --- a/include/linux/swiotlb.h > +++ b/include/linux/swiotlb.h > @@ -110,7 +110,6 @@ struct io_tlb_mem { > atomic_long_t used_hiwater; > #endif > }; > -extern struct io_tlb_mem io_tlb_default_mem; > > static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) > { > @@ -128,13 +127,22 @@ static inline bool is_swiotlb_force_bounce(struct device *dev) > > void swiotlb_init(bool addressing_limited, unsigned int flags); > void __init swiotlb_exit(void); > +void swiotlb_dev_init(struct device *dev); > size_t swiotlb_max_mapping_size(struct device *dev); > +bool is_swiotlb_allocated(void); > bool is_swiotlb_active(struct device *dev); > void __init swiotlb_adjust_size(unsigned long size); > +phys_addr_t default_swiotlb_start(void); > +phys_addr_t default_swiotlb_limit(void); Usually we use start/end, base/limit, low[est]/high[est] tuples. Possibly clearer to rename, regardless: Reviewed-by: Philippe Mathieu-Daudé > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index 2b83e3ad9dca..873b077d7e37 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c > @@ -958,6 +975,26 @@ bool is_swiotlb_active(struct device *dev) > } > EXPORT_SYMBOL_GPL(is_swiotlb_active); > > +/** > + * default_swiotlb_start() - get the start of the default SWIOTLB > + * > + * Get the lowest physical address used by the default software IO TLB pool. > + */ > +phys_addr_t default_swiotlb_start(void) > +{ > + return io_tlb_default_mem.start; > +} > + > +/** > + * default_swiotlb_limit() - get the highest address in the default SWIOTLB > + * > + * Get the highest physical address used by the default software IO TLB pool. (note you describe lowest/highest). > + */ > +phys_addr_t default_swiotlb_limit(void) > +{ > + return io_tlb_default_mem.end - 1; > +} > + > #ifdef CONFIG_DEBUG_FS > > static int io_tlb_used_get(void *data, u64 *val)