From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 27 Mar 2007 15:30:04 +0100 (BST) Received: from h155.mvista.com ([63.81.120.155]:62950 "EHLO imap.sh.mvista.com") by ftp.linux-mips.org with ESMTP id S20021892AbXC0OaC (ORCPT ); Tue, 27 Mar 2007 15:30:02 +0100 Received: from [192.168.1.248] (unknown [10.150.0.9]) by imap.sh.mvista.com (Postfix) with ESMTP id 5C3293ECA; Tue, 27 Mar 2007 07:29:27 -0700 (PDT) Message-ID: <46092A6F.9010800@ru.mvista.com> Date: Tue, 27 Mar 2007 18:30:07 +0400 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Marc St-Jean Cc: akpm@linux-foundation.org, linux-mips@linux-mips.org Subject: Re: [PATCH 6/12] drivers: PMC MSP71xx serial driver References: <200703262159.l2QLxIDh013039@pasqua.pmc-sierra.bc.ca> In-Reply-To: <200703262159.l2QLxIDh013039@pasqua.pmc-sierra.bc.ca> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 14728 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sshtylyov@ru.mvista.com Precedence: bulk X-list: linux-mips Hello. Marc St-Jean wrote: > Patch to add serial driver support for the PMC-Sierra > MSP71xx devices. > Reposting patches as a single set at the request of akpm. > Only 9 of 12 will be posted at this time, 3 more to follow > when cleanups are complete. > Thanks, > Marc > Signed-off-by: Marc St-Jean > --- > Re-posting patch with recommended changes: > -Implemented support for putchar() in msp_serial.c > diff --git a/arch/mips/pmc-sierra/msp71xx/msp_serial.c b/arch/mips/pmc-sierra/msp71xx/msp_serial.c > new file mode 100644 > index 0000000..3b956e9 > --- /dev/null > +++ b/arch/mips/pmc-sierra/msp71xx/msp_serial.c > @@ -0,0 +1,185 @@ [...] > +#ifdef CONFIG_KGDB > +/* > + * kgdb uses serial port 1 so the console can remain on port 0. > + * To use port 0 change the definition to read as follows: > + * #define DEBUG_PORT_BASE KSEG1ADDR(MSP_UART0_BASE) > + */ > +#define DEBUG_PORT_BASE KSEG1ADDR(MSP_UART1_BASE) > + > +int putDebugChar(char c) > +{ > + volatile uint32_t *uart = (volatile uint32_t *)DEBUG_PORT_BASE; > + uint32_t val = (uint32_t)c; > + > + local_irq_disable(); > + while (!(uart[5] & 0x20)); /* Wait for TXRDY */ > + uart[0] = val; > + while (!(uart[5] & 0x20)); /* Wait for TXRDY */ > + local_irq_enable(); Gah, why you decided to put local_irq_enable() there?! KGDB expects interrupts to be *disabled* while it has control, else some subtle state corruptions will ensue, and it will eventually lock up. Please remove these 2 calls completely. WBR, Sergei