From: Pierre Ossman <drzeus@drzeus.cx>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] mmc: au1xmmc command types check from data flags
Date: Fri, 11 May 2007 17:48:53 +0200 [thread overview]
Message-ID: <46449065.3050904@drzeus.cx> (raw)
In-Reply-To: <20070511192948.38937fd0.yoichi_yuasa@tripeaks.co.jp>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
Yoichi Yuasa wrote:
>
> Ok, I updated the patch for au1xmmc.c .
>
> This patch has changed command types check from data flags.
>
Perfect. That's just the way things should be.
> MMC_STOP_TRANSMISSION is never passed to au1xmmc_send_command().
> SEND_STOP() is used for MMC_STOP_TRANSMISSION.
>
That SEND_STOP however is a long standing bug in this driver. Could I bother you
with fixing the driver so that it respects mrq->data->stop?
Rgds
Pierre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]
prev parent reply other threads:[~2007-05-11 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 3:59 [PATCH] mmc: add include <linux/mmc/mmc.h> to au1xmmc.c Yoichi Yuasa
2007-05-11 4:47 ` Pierre Ossman
2007-05-11 5:16 ` Yoichi Yuasa
2007-05-11 5:20 ` Pierre Ossman
2007-05-11 10:29 ` [PATCH] mmc: au1xmmc command types check from data flags Yoichi Yuasa
2007-05-11 11:07 ` Manuel Lauss
2007-05-11 11:27 ` Yoichi Yuasa
2007-05-11 15:48 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46449065.3050904@drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=linux-mips@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox