From: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: david-b@pacbell.net, gregkh@suse.de, linux-mips@linux-mips.org,
akpm@linux-foundation.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driv er
Date: Tue, 5 Jun 2007 17:47:12 -0700 [thread overview]
Message-ID: <46660410.3070703@pmc-sierra.com> (raw)
Alan Stern wrote:
> On Mon, 4 Jun 2007, Marc St-Jean wrote:
>
> > [PATCH 11/12] drivers: PMC MSP71xx USB driver
> >
> > Patch to add an USB driver for the PMC-Sierra MSP71xx devices.
> >
> > Patches 1 through 10 were posted to linux-mips@linux-mips.org as well
> > as other sub-system lists/maintainers as appropriate. This patch has
> > some dependencies on the first few patches in the set. If you would
> > like to receive these or the entire set, please email me.
>
> My personal impressions:
>
> This does far too much to be a single patch. It needs to be broken up.
>
> The change to hub.c looks more complicated than necessary. You ought
> to be able to share more of the code. Turning off power to the
> overcurrent port would probably be okay for any hub.
>
> The changes to file_storage.c and other gadget drivers look completely
> unnecessary. You're apparently trying to disallow 0-length transfers
> on endpoint 0. For one thing, that's liable to break some protocols.
> For another, it would be better to make the test at one place, in your
> controller driver, instead of spread out among multiple gadget drivers.
>
> Alan Stern
Thanks to everyone that provided feedback. I'll be resubmitting the host
code only and will resume with gadget once the host is accepted.
The host only patch is still ~50k but that's mostly due to all the
le32 -> ehci32 conversion in order to support the big endian controller.
The actual platform driver code is small.
Marc
reply other threads:[~2007-06-06 0:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46660410.3070703@pmc-sierra.com \
--to=marc_st-jean@pmc-sierra.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox