Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Nigel Stephens <nigel@mips.com>
To: Franck <vagabon.xyz@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	linux-mips <linux-mips@linux-mips.org>
Subject: Re: [RFC] User stack pointer randomisation
Date: Thu, 19 Jul 2007 10:43:03 +0100	[thread overview]
Message-ID: <469F3227.6090307@mips.com> (raw)
In-Reply-To: <469F0E5F.4050005@innova-card.com>



Franck Bui-Huu wrote:
> +/*
> + * Don't forget that the stack pointer must be aligned on a 8 bytes
> + * boundary at least.
> + */
> +unsigned long arch_align_stack(unsigned long sp)
> +{
> +	if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
> +		sp -= get_random_int() & ~PAGE_MASK;
> +
> +	return sp & ~7;
> +}
>   

For the 64-bit ABIs (N32 & N64) the stack must be 16 byte aligned.

Nigel

  reply	other threads:[~2007-07-19  9:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-19  7:10 [RFC] User stack pointer randomisation Franck Bui-Huu
2007-07-19  9:43 ` Nigel Stephens [this message]
2007-07-19 11:36   ` Franck Bui-Huu
2007-07-19 11:14 ` Ralf Baechle
2007-07-19 11:47   ` Franck Bui-Huu
2007-07-19 12:01     ` Ralf Baechle
2007-07-19 12:19       ` Franck Bui-Huu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469F3227.6090307@mips.com \
    --to=nigel@mips.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=vagabon.xyz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox