From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: Modpost warning on Alchemy
Date: Wed, 01 Aug 2007 20:37:08 +0400 [thread overview]
Message-ID: <46B0B6B4.5090103@ru.mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.64N.0708011708250.20314@blysk.ds.pg.gda.pl>
Maciej W. Rozycki wrote:
>> PCI config. space is mapped at 0x600000000, well beyond KGSEG0/1.
> It is still just fine with ioremap() -- it will simply use KSEG2 in this
> case. You cannot bypass the TLB here with a 32-bit processor no matter
> what.
> And regarding what you have written above and the size issue you
> mentioned in another e-mail (do you map the whole PCI config space
> linearly in the physical address space of the CPU or suchlike?) -- PCI
No, I don't. But that was why the original code preferred the wired entry
approach over ioremap() -- not to map a whole range...
> config space accesses are rare (by design rather than chance), so
That depends on the drivers used (some IDE drivers access it really often).
> performance is a non-issue and it should be absolutely fine for you to
> call ioremap() and iounmap() in code specific for your PCI host bridge for
> the required fragment upon every access. There is no need for a permanent
That's an idea -- however, as the currecnt code uses a cached mapping,
this part would certainly need to be saved in the new implementaion -- if
someone will go and fix it eventually. :-)
> map here. You probably waste more performance by taking away a TLB entry
> to wire it anyway.
No, I didn't write that code. :-)
>> Thanks for wasting time on my education about MIPS. ;-)
> Well, more about Linux perhaps than MIPS in general. :-)
Let's say that was about Linux/MIPS. But the key word was "wasting". ;-)
> Maciej
WBR, Sergei
next prev parent reply other threads:[~2007-08-01 16:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 11:52 Modpost warning on Alchemy Ralf Baechle
2007-08-01 12:23 ` Sergei Shtylyov
2007-08-01 12:53 ` Maciej W. Rozycki
2007-08-01 13:13 ` Sergei Shtylyov
2007-08-01 13:18 ` Sergei Shtylyov
2007-08-01 15:38 ` Maciej W. Rozycki
2007-08-01 15:44 ` Sergei Shtylyov
2007-08-01 16:26 ` Maciej W. Rozycki
2007-08-01 16:37 ` Sergei Shtylyov [this message]
2007-08-01 16:54 ` Maciej W. Rozycki
2007-08-01 17:06 ` Sergei Shtylyov
2007-08-02 9:14 ` Maciej W. Rozycki
2007-08-02 12:49 ` Sergei Shtylyov
2007-08-02 13:27 ` Maciej W. Rozycki
2007-08-02 14:15 ` Sergei Shtylyov
2007-08-02 14:33 ` Maciej W. Rozycki
2007-08-01 17:10 ` Alan Cox
2007-08-02 9:24 ` Maciej W. Rozycki
2007-08-01 17:09 ` Sergei Shtylyov
2007-08-02 9:39 ` Maciej W. Rozycki
2007-08-02 10:15 ` Ralf Baechle
2007-08-02 10:17 ` Maciej W. Rozycki
2007-08-02 12:53 ` Sergei Shtylyov
2007-08-02 13:00 ` Sergei Shtylyov
2007-08-02 13:35 ` Maciej W. Rozycki
2007-08-02 14:10 ` Sergei Shtylyov
2007-08-02 14:21 ` Maciej W. Rozycki
2007-08-01 15:39 ` Alan Cox
2007-08-01 15:49 ` Maciej W. Rozycki
2007-08-01 15:58 ` Alan Cox
2007-08-01 16:00 ` Maciej W. Rozycki
2007-08-01 16:21 ` Ralf Baechle
2007-08-01 16:33 ` Maciej W. Rozycki
2007-08-02 9:25 ` Ralf Baechle
2007-08-02 9:44 ` Maciej W. Rozycki
2007-08-01 16:01 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B0B6B4.5090103@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox