From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: Linux MIPS PCI resource sanity check
Date: Sat, 16 Feb 2008 13:49:56 +0300 [thread overview]
Message-ID: <47B6BFD4.5050404@ru.mvista.com> (raw)
In-Reply-To: <200802161139.10791.mb@bu3sch.de>
Michael Buesch wrote:
> There's a sanity check in pcibios_enable_resources() that looks like this:
> r = &dev->resource[idx];
> if (!r->start && r->end) {
> printk(KERN_ERR "PCI: Device %s not available because of resource collisions\n", pci_name(dev));
> return -EINVAL;
> }
>
> What is this check actually doing?
It makes sure that a PCI resource is allocated (base of 0 means that it's
unallocated due to previously detected resource conlict (or some other reason).
> It triggers for me on a BCM4318 device which is behind a BCM4710 PCI bridge.
> r->start is 0 and r->end is 0x1FFF when this triggers.
> If I simply comment out that check the device is detected correctly
> and seems to initialize just fine.
No, that failnig resource should be relocated.
WBR, Sergei
next prev parent reply other threads:[~2008-02-16 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 10:39 Linux MIPS PCI resource sanity check Michael Buesch
2008-02-16 10:49 ` Sergei Shtylyov [this message]
2008-02-16 10:55 ` Michael Buesch
2008-02-16 23:35 ` Andrew Sharp
2008-02-17 11:19 ` Michael Buesch
2008-02-18 13:55 ` Sergei Shtylyov
2008-02-19 15:30 ` Ralf Baechle
2008-02-19 15:51 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B6BFD4.5050404@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=mb@bu3sch.de \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox