From: David Daney <ddaney@avtrex.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [MIPS] Fix handling of trap and breakpoint instructions
Date: Mon, 21 Apr 2008 08:47:52 -0700 [thread overview]
Message-ID: <480CB728.7060402@avtrex.com> (raw)
In-Reply-To: <20080421.100721.07644724.nemoto@toshiba-tops.co.jp>
Atsushi Nemoto wrote:
>> Author: Ralf Baechle <ralf@linux-mips.org> Sun Apr 20 16:28:54 2008 +0100
>> Commit: 5881bb0de64887a60f7f49922cf73a3b4d40fc01
>> Gitweb: http://www.linux-mips.org/g/linux/5881bb0d
>> Branch: master
>
> You must drop left shift of this line too.
>
> if (bcode == (BRK_DIVZERO << 10))
>
Note that there has been some confusion about break codes in gas over
the years. Ancient versions (I am not sure which) generated different
break codes than recent versions.
Before changing it make sure that you don't break existing user space code.
One problem (fixed around 2.4.25 or so) was the integer division by zero
in user space would result in SIGTRAP instead of SIGFPE. If you change
the break code handling you should verify that you don't break this.
David Daney
next prev parent reply other threads:[~2008-04-21 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S20041689AbYDUAiN/20080421003813Z+6727@ftp.linux-mips.org>
2008-04-21 1:07 ` [MIPS] Fix handling of trap and breakpoint instructions Atsushi Nemoto
2008-04-21 9:30 ` Ralf Baechle
2008-04-21 15:47 ` David Daney [this message]
2008-04-21 16:12 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480CB728.7060402@avtrex.com \
--to=ddaney@avtrex.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox