Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] Pb1200/DBAu1200: move platform code to its proper place (take 2)
Date: Mon, 28 Apr 2008 17:03:46 +0400	[thread overview]
Message-ID: <4815CB32.4040605@ru.mvista.com> (raw)
In-Reply-To: <200804262321.46298.sshtylyov@ru.mvista.com>

Hello, I wrote:

> Since both the IDE interface and SMC 91C111 Ethernet chip are on-board devices,
> move the platform device registration form the common to board specific code.

> While at it, do some renaming:

> - change 'au1200_ide0_' variable name prefix to the mere 'ide_';

> - change 'smc91x_' variable name prefix to 'smc91c111_';

> - drop 'AU1XXX_' prefix from the macro names;

> - change 'SMC91C111_' to 'SMC91C111_', change 'IRQ' to 'INT' for consistency
>   in the Ethernet chip macro names;

   Oops, that should read "change 'SMC91111_' to 'SMC91C111_'", thanks to 
Miachel Wood for spotting that

> - change 'ATA_' to 'IDE_' and 'OFFSET' to 'SHIFT' (since this value is indeed
>   a shift count) in the IDE interface macro names.

    Additionally, I've removed semicolon from IDE_DDMA_REQ which didn't break 
things only because the macro wasn't ever used in aggregate initializer.

> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> ---
> Oops, needed one more rename. :-)
> This patch is atop of my two recent SMC 91C1111 platform device fixes.

    It's 91C111, dammit...

WBR, Sergei

  parent reply	other threads:[~2008-04-28 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 19:21 [PATCH] Pb1200/DBAu1200: move platform code to its proper place (take 2) Sergei Shtylyov
2008-04-28 12:02 ` Ralf Baechle
2008-04-28 13:03 ` Sergei Shtylyov [this message]
2008-04-28 13:07   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4815CB32.4040605@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox