Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
To: Kevin Hickey <khickey@rmicorp.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/1] Initialization of Alchemy boards
Date: Mon, 28 Jul 2008 17:16:08 +0300	[thread overview]
Message-ID: <488DD4A8.6040209@movial.fi> (raw)
In-Reply-To: <1217254063.9208.3.camel@kh-ubuntu.razamicroelectronics.com>

Kevin Hickey wrote:
> Dmitri,
> 
> On Mon, 2008-07-28 at 10:08 +0300, Dmitri Vorobiev wrote:
>> Kevin Hickey wrote:
>>> I found this when I updated to version 2.6.26.  None of my development
>>> boards would boot.  It appears that a previous update changed some calls
>>> to simple_strtol to strict_strtol but did not account for the different
>>> call semantics.
>> Hi Kevin,
>>
>> 1) you forgot to sign your patch off;
> Indeed I did.  Is it sufficient to reply to the original post and add a
> sign-off line?

Well, I think it would be better to recreate the diff. What you have now does not apply:

dvorobye@sd048:/work/zoo/src/linux-2.6$ git apply

[pasted the patch]

error: mips/au1000/pb1000/init.c: No such file or directory
error: mips/au1000/pb1100/init.c: No such file or directory
error: mips/au1000/pb1200/init.c: No such file or directory
error: mips/au1000/mtx-1/init.c: No such file or directory
error: mips/au1000/pb1500/init.c: No such file or directory
error: mips/au1000/xxs1500/init.c: No such file or directory
error: mips/au1000/pb1550/init.c: No such file or directory
error: mips/au1000/db1x00/init.c: No such file or directory
dvorobye@sd048:/work/zoo/src/linux-2.6$

For a quick intro to creating the kernel patches, please see Documentation/SubmittingPatches, which describes the gitless approach. However, as I mentioned earlier, using git is much better.

Thanks,
Dmitri

  reply	other threads:[~2008-07-28 14:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 16:13 [PATCH 1/1] Initialization of Alchemy boards Kevin Hickey
2008-07-28  7:08 ` Dmitri Vorobiev
2008-07-28 14:07   ` Kevin Hickey
2008-07-28 14:16     ` Dmitri Vorobiev [this message]
2008-07-28 11:03 ` Sergei Shtylyov
2008-07-28 18:16   ` Sergei Shtylyov
2008-07-28 14:11 ` Kevin Hickey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488DD4A8.6040209@movial.fi \
    --to=dmitri.vorobiev@movial.fi \
    --cc=khickey@rmicorp.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox