Re: [PATCH v4 7/10] Alchemy: split core PM code from sysctl parts.

[Manuel Lauss <mlau@msc-ge.com>]

Dmitri Vorobiev wrote:
> Manuel Lauss wrote:
>> The Alchemy power.c file contains both core suspend/resume code, which
>> is processor specific, and leftovers of the 2.4 PM userspace interface
>> (sysctls).
>>
>> This patch moves the userspace interface to the platform.c file and
>> leaves the core board-independent suspend/resume parts which should be
>> usable for all Alchemy-based systems intact.
>>
>> Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
>> ---
>>  arch/mips/au1000/common/platform.c |  304 ++++++++++++++++++++++++++++++++++-
>>  arch/mips/au1000/common/power.c    |  317 +-----------------------------------
>>  2 files changed, 305 insertions(+), 316 deletions(-)
>>
>> diff --git a/arch/mips/au1000/common/platform.c b/arch/mips/au1000/common/platform.c
>> index 66d6770..1e89560 100644
>> --- a/arch/mips/au1000/common/platform.c
>> +++ b/arch/mips/au1000/common/platform.c
[...]
>> +	/**
>> +	 ** The code below is all system dependent and we should probably
>> +	 ** have a function call out of here to set this up.  You need
>> +	 ** to configure the GPIO or timer interrupts that will bring
>> +	 ** you out of sleep.
>> +	 ** For testing, the TOY counter wakeup is useful.
>> +	 **/
>> +#if 0
> 
> Why not simply remove the dead code while you're at it?

That code is removed by a later patch in the series.  This patch is
just code reshuffling; I wanted to leave everything (as broken) as
it was.

Thanks,
	Manuel Lauss