From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-mips <linux-mips@linux-mips.org>, ralf@linux-mips.org
Subject: Re: [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address
Date: Fri, 22 Aug 2008 13:41:16 +0400 [thread overview]
Message-ID: <48AE89BC.3070204@ru.mvista.com> (raw)
In-Reply-To: <200808220014.39030.florian@openwrt.org>
Hello.
Florian Fainelli wrote:
> This patch removes the superfluous double KSEG1ADDR
> against the base register in the setup code.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/arch/mips/rb532/setup.c b/arch/mips/rb532/setup.c
> index 7aafa95..6d3286e 100644
> --- a/arch/mips/rb532/setup.c
> +++ b/arch/mips/rb532/setup.c
> @@ -10,6 +10,7 @@
> #include <linux/ioport.h>
>
> #include <asm/mach-rc32434/rc32434.h>
> +#include <asm/mach-rc32434/rb.h>
> #include <asm/mach-rc32434/pci.h>
>
> struct pci_reg __iomem *pci_reg;
> @@ -27,7 +28,7 @@ static struct resource pci0_res[] = {
> static void rb_machine_restart(char *command)
> {
> /* just jump to the reset vector */
> - writel(0x80000001, (void *)KSEG1ADDR(RC32434_REG_BASE + RC32434_RST));
> + writel(0x80000001, (void *)KSEG1ADDR(REG_BASE + RC32434_RST));
>
Why not just leave RC32434_REG_BASE + RC32434_RST and remove
KSEG1ADDR? BTW, the cast could be removed as well, since it's already a
part of RC32434_REG_BASE...
WBR, Sergei
next prev parent reply other threads:[~2008-08-22 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 22:14 [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address Florian Fainelli
2008-08-22 9:41 ` Sergei Shtylyov [this message]
2008-08-22 14:45 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AE89BC.3070204@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox