Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Dinar Temirbulatov <dtemirbulatov@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: mmap is broken for MIPS64 n32 and o32 abis
Date: Fri, 19 Sep 2008 14:14:53 +0400	[thread overview]
Message-ID: <48D37B9D.8060500@ru.mvista.com> (raw)
In-Reply-To: <a664af430809182331i41c9e344w83ecb2830ac24@mail.gmail.com>

Hello.

Dinar Temirbulatov wrote:

> I noticed that mmap is not working properly under n32, o32 abis in
> MIPS64, for example if we want to map 0xb6000000 address to the
> userland under those abis we call  mmap and because the last argument
> in old_mmap is off_t and this type is 64-bits wide for MIPS64, we end
> up having for example 0xffffffffb6000000 address value. I am sure that
> this is not a glibc issue. Following patch adds 32-bit version of mmap
> and also it adds mmap64 support for n32 abi since mmap64 was
> implemented correctly for n32 too.
>                                           thanks, Dinar.
>   

  Your patch (BTW, how come it didn't get quoted? -- ah, it's 
text/x-patch) is using both tabs and spaces for indentation. Please use 
tabs only.
And either attach patches as text/plain or include them inline.

WBR, Sergei

  reply	other threads:[~2008-09-19 10:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19  6:31 mmap is broken for MIPS64 n32 and o32 abis Dinar Temirbulatov
2008-09-19 10:14 ` Sergei Shtylyov [this message]
2008-09-19 12:33 ` Maciej W. Rozycki
2008-09-19 16:53   ` Dinar Temirbulatov
2008-09-19 17:25     ` Maciej W. Rozycki
2008-09-21 10:55       ` Dinar Temirbulatov
2008-09-23 12:32         ` Maciej W. Rozycki
2008-09-25 12:34           ` Dinar Temirbulatov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D37B9D.8060500@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=dtemirbulatov@gmail.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox