From: David Daney <ddaney@caviumnetworks.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Johannes Dickgreber <tanzy@gmx.de>, linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i think is wrong.
Date: Mon, 13 Oct 2008 16:34:17 -0700 [thread overview]
Message-ID: <48F3DAF9.5000603@caviumnetworks.com> (raw)
In-Reply-To: <20081013222146.GD8145@linux-mips.org>
Ralf Baechle wrote:
> On Mon, Oct 13, 2008 at 07:36:21PM +0200, Johannes Dickgreber wrote:
>
>> Cc: linux-mips@linux-mips.org
>> Subject: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i
>> think is wrong.
>
> Patch is correct and so I applied it. Not a big issue though. There is
> only one system supported currently that supports a mix of different
> processor types (IP27) and those are very similar so it doesn't cause
> pain.
>
> Ralf
The patch is required on SMP systems as without it you get:
BUG: using smp_processor_id() in preemptible [00000000] code: cat/687
caller is show_cpuinfo+0xc4/0x500
Call Trace:
[<ffffffff8111f4c8>] dump_stack+0x8/0x38
[<ffffffff812c235c>] debug_smp_processor_id+0xec/0x100
[<ffffffff8112de64>] show_cpuinfo+0xc4/0x500
[<ffffffff811d4128>] seq_read+0x2f8/0x420
[<ffffffff811fb658>] proc_reg_read+0x90/0xd8
[<ffffffff811b05ec>] vfs_read+0xbc/0x160
[<ffffffff811b0a88>] sys_read+0x50/0x98
[<ffffffff81129224>] handle_sysn32+0x44/0x84
David Daney
next prev parent reply other threads:[~2008-10-13 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 17:36 [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i think is wrong Johannes Dickgreber
2008-10-13 22:21 ` Ralf Baechle
2008-10-13 23:34 ` David Daney [this message]
2008-10-14 8:36 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F3DAF9.5000603@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tanzy@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox